added offsetbias execute prompt and judgement process code #159
+87
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sanghyuk-choi need some changes to support this model. E.g. which version of VLLM do we need? Seems like we at least need that (could not run this on my previous image). EDIT: This may be a different issue in run_generative, checking. |
|
@sanghyuk-choi I made changes directly here: sanghyuk-choi#1 |
|
Scores are live, so we should be able to merge this soon. |
cleaning / finishing pr
|
also I have fixed my mistake by adding model_modifier when calling process_judgement in run_judge_pair function. |
|
Nice, yeah @sanghyuk-choi this looks good. Sorry for lumping a bunch of small fixes into your code, I got a little carried away. merging as long as checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just added prompt and judgement code for NCSOFT/Llama-3-OffsetBias-8B.