Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge_preserving_smoothing_3d should account for voxel spacing #4

Open
mdylan2 opened this issue Mar 6, 2020 · 2 comments
Open

edge_preserving_smoothing_3d should account for voxel spacing #4

mdylan2 opened this issue Mar 6, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@mdylan2
Copy link

mdylan2 commented Mar 6, 2020

Edge preserving smoothing in 3D depends on voxel spacing. Below is the code you currently have for edge_preserving_smoothing_3d under aicssegmentation/core/pre_processing_utils.
image

Rather, this is what I think should be incorporated:
image

What are your thoughts?

@mdylan2 mdylan2 closed this as completed Mar 6, 2020
@mdylan2 mdylan2 reopened this Mar 6, 2020
@jxchen01
Copy link
Contributor

jxchen01 commented Mar 6, 2020

First of all, by default, we are using [1.0, 1.0, 1.0] spacing in our segmentation algorithms even though our images are not isotropic. In practice, in our images (ZYX = 0.29 x 0.108 x 0.108 micron), I find that results obtained by isotropic spacing, i.e. [1, 1, 1], are usually more consistent with what I expect intuitively, than using the true image spacing. So, we decide to make the wrapper without requiring users to set the spacing and use [1.0, 1.0, 1.0] by default.

@jxchen01
Copy link
Contributor

jxchen01 commented Mar 6, 2020

Technically, the issue you pointed out is true, where users can change the spacing if they need. I will fix it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants