Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and tested misleading error messages on creating Alarm #193

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

mreiche
Copy link
Contributor

@mreiche mreiche commented Jun 9, 2023

No description provided.

Copy link
Owner

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I missed this PR! Thank you for sending. I have one comment about test simplification.

tests/test_alarm.py Outdated Show resolved Hide resolved
@mreiche mreiche requested a review from allenporter June 20, 2023 07:55
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #193 (ed289d2) into main (b7201fc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   96.75%   96.77%   +0.02%     
==========================================
  Files          44       44              
  Lines        2591     2608      +17     
==========================================
+ Hits         2507     2524      +17     
  Misses         84       84              
Impacted Files Coverage Δ
ical/alarm.py 98.11% <100.00%> (+0.07%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@allenporter allenporter merged commit 855cf1b into allenporter:main Jun 20, 2023
7 of 8 checks passed
@allenporter
Copy link
Owner

Thank you @mreiche 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants