Merge pull request #986 from alleslabs/fix/bugbash-lite-peach2

fix: creator, sorting name in validator
alleslabs · Jun 21, 2024 · 0cc8911 · 0cc8911
2 parents a4e5404 + 5b9dfa0
commit 0cc8911
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -101,6 +101,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Bug fixes
 
+- [#986](https://github.com/alleslabs/celatone-frontend/pull/986) Fix bugbash lite version (creator, sorting name in validator)
 - [#985](https://github.com/alleslabs/celatone-frontend/pull/985) Fix proposal details lite version bugs
 - [#987](https://github.com/alleslabs/celatone-frontend/pull/987) Fix bug bash (query redirection, module button color, modal open/close, migration contract radio button, txs count in account detail)
 - [#989](https://github.com/alleslabs/celatone-frontend/pull/989) Change tomcat endpoints

diff --git a/src/lib/pages/module-details/components/ModuleTop.tsx b/src/lib/pages/module-details/components/ModuleTop.tsx
@@ -8,7 +8,6 @@ import {
   useCurrentChain,
   useInternalNavigate,
   useMobile,
-  useTierConfig,
 } from "lib/app-provider";
 import { Breadcrumb } from "lib/components/Breadcrumb";
 import { CopyButton } from "lib/components/copy";
@@ -36,7 +35,6 @@ export const ModuleTop = ({ moduleData, isVerified }: ModuleTopProps) => {
   const isMobile = useMobile();
   const navigate = useInternalNavigate();
   const { address } = useCurrentChain();
-  const isFullTier = useTierConfig() === "full";
   const { convertHexWalletAddress, convertHexModuleAddress } =
     useConvertHexAddress();
 
@@ -226,25 +224,23 @@ export const ModuleTop = ({ moduleData, isVerified }: ModuleTopProps) => {
             type="module_path"
           />
         </Flex>
-        {isFullTier && (
-          <Flex
-            mt={{ base: 2, md: 0 }}
-            gap={{ base: 0, md: 2 }}
-            direction={{ base: "column", md: "row" }}
-          >
-            <Text {...baseTextStyle} color="text.main">
-              Creator:
-            </Text>
-            <ExplorerLink
-              value={moduleAddress}
-              ampCopierSection="module_top"
-              textFormat="normal"
-              maxWidth="fit-content"
-              type="user_address"
-              fixedHeight={false}
-            />
-          </Flex>
-        )}
+        <Flex
+          mt={{ base: 2, md: 0 }}
+          gap={{ base: 0, md: 2 }}
+          direction={{ base: "column", md: "row" }}
+        >
+          <Text {...baseTextStyle} color="text.main">
+            Creator:
+          </Text>
+          <ExplorerLink
+            value={moduleAddress}
+            ampCopierSection="module_top"
+            textFormat="normal"
+            maxWidth="fit-content"
+            type="user_address"
+            fixedHeight={false}
+          />
+        </Flex>
         <Flex
           mt={{ base: 2, md: 0 }}
           gap={{ base: 0, md: 2 }}

diff --git a/src/lib/pages/validators/utils.ts b/src/lib/pages/validators/utils.ts
@@ -18,7 +18,8 @@ export const compareValidator =
     let isLower = true;
     if (order === ValidatorOrder.Commission)
       isLower = a.commissionRate < b.commissionRate;
-    else if (order === ValidatorOrder.Moniker) isLower = a.moniker < b.moniker;
+    else if (order === ValidatorOrder.Moniker)
+      isLower = a.moniker.toLowerCase() < b.moniker.toLowerCase();
     else
       isLower = a.votingPower.eq(b.votingPower)
         ? a.moniker > b.moniker