Merge pull request #122 from alleslabs/fix/incorrect-unknown-block-he…

…ight-rendering fix unknown code upload block height
alleslabs · Jan 24, 2023 · 9554a90 · 9554a90 · vercel · Jan 24, 2023
2 parents a6d966c + 10b31ed
commit 9554a90
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -39,6 +39,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Features
 
+- [#122](https://github.com/alleslabs/celatone-frontend/pull/122) Fix unknown code upload block height
 - [#125](https://github.com/alleslabs/celatone-frontend/pull/125) Add connect wallet alert in instantiate page
 - [#126](https://github.com/alleslabs/celatone-frontend/pull/126) Add port id copier for IBC port id
 - [#121](https://github.com/alleslabs/celatone-frontend/pull/121) Fix code snippet for query axios

diff --git a/src/lib/pages/code-details/components/CodeInfoSection.tsx b/src/lib/pages/code-details/components/CodeInfoSection.tsx
@@ -28,7 +28,7 @@ const getMethodSpecificRender = (
           />
         </LabelText>
       ),
-      storedBlockRender: (
+      storedBlockRender: codeProposalInfo.height ? (
         <>
           <ExplorerLink
             type="block_height"
@@ -42,6 +42,8 @@ const getMethodSpecificRender = (
             {formatUTC(codeProposalInfo.created)}
           </Text>
         </>
+      ) : (
+        <Text variant="body2">N/A</Text>
       ),
     };
   }

diff --git a/src/lib/services/codeService.ts b/src/lib/services/codeService.ts
@@ -133,7 +133,7 @@ export const useCodeInfoByCodeId = (
           proposal: codes_by_pk.code_proposals[0]
             ? {
                 proposalId: codes_by_pk.code_proposals[0].proposal_id,
-                height: codes_by_pk.code_proposals[0].block?.height ?? 0,
+                height: codes_by_pk.code_proposals[0].block?.height,
                 created: parseDateDefault(
                   codes_by_pk.code_proposals[0].block?.timestamp
                 ),

diff --git a/src/lib/types/code.ts b/src/lib/types/code.ts
@@ -21,7 +21,7 @@ export interface CodeInfo extends CodeLocalInfo {
 
 interface CodeProposal {
   proposalId: number;
-  height: number;
+  height: Option<number>;
   created: Date;
 }