Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date #158

Merged
merged 3 commits into from
Feb 3, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Bug fixes

- [#158](https://github.com/alleslabs/celatone-frontend/pull/158) Change dayjs back to Date type as it is incompatible with mobx storage
- [#137](https://github.com/alleslabs/celatone-frontend/pull/137) Throw error instead of returning undefined in query function
- [#148](https://github.com/alleslabs/celatone-frontend/pull/148) Fix scrolling to table header on first land
- [#146](https://github.com/alleslabs/celatone-frontend/pull/146) Fix contract select always fetch when theres no contract address, edit query keys
Expand Down
5 changes: 2 additions & 3 deletions src/lib/app-fns/tx/execute.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,14 @@ import type {
} from "@cosmjs/cosmwasm-stargate";
import type { Coin, StdFee } from "@cosmjs/stargate";
import { pipe } from "@rx-stream/pipe";
import dayjs from "dayjs";
import { MdCheckCircle } from "react-icons/md";
import type { Observable } from "rxjs";

import { ExplorerLink } from "lib/components/ExplorerLink";
import type { Activity } from "lib/stores/contract";
import type { ContractAddr, TxResultRendering } from "lib/types";
import { TxStreamPhase } from "lib/types";
import { encode, formatUFee } from "lib/utils";
import { encode, formatUFee, getCurrentDate } from "lib/utils";

import { catchTxError, postTx, sendingTx } from "./common";

Expand Down Expand Up @@ -53,7 +52,7 @@ export const executeContractTx = ({
sender: address,
contractAddress,
msg: encode(JSON.stringify(msg)), // base64
timestamp: dayjs(),
timestamp: getCurrentDate(),
});
return {
value: null,
Expand Down
5 changes: 2 additions & 3 deletions src/lib/components/modal/select-contract/ContractListCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,12 @@ import {
Spacer,
chakra,
} from "@chakra-ui/react";
import dayjs from "dayjs";
import { MdMoreHoriz, MdMode, MdDelete } from "react-icons/md";

import { EditList, RemoveList } from "../list";
import { getListIcon, INSTANTIATED_LIST_NAME } from "lib/data";
import type { ContractListInfo } from "lib/stores/contract";
import { formatSlugName } from "lib/utils";
import { dateFromNow, formatSlugName } from "lib/utils";

const StyledIcon = chakra(Icon, {
baseStyle: {
Expand Down Expand Up @@ -84,7 +83,7 @@ export const ContractListCard = ({
</Flex>
{showLastUpdated && (
<Text variant="body3" color="text.dark">
Updated {dayjs(item.lastUpdated).toNow(true)} ago
Updated {dateFromNow(item.lastUpdated)}
</Text>
)}
</Flex>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ import {
Heading,
} from "@chakra-ui/react";
import { useWallet } from "@cosmos-kit/react";
import dayjs from "dayjs";
import { MdList, MdSwapHoriz } from "react-icons/md";

import { ADMIN_SPECIAL_SLUG } from "lib/data";
import { useContractStore } from "lib/hooks";
import { useContractListByAdmin } from "lib/services/contractService";
import type { ContractListInfo, ContractLocalInfo } from "lib/stores/contract";
import type { ContractAddr, HumanAddr } from "lib/types";
import { getCurrentDate } from "lib/utils";

import { ContractListDetail } from "./ContractListDetail";

Expand All @@ -43,7 +43,7 @@ export const SelectContractAdmin = ({
...contract,
...getContractLocalInfo(contract.contractAddress),
})),
lastUpdated: dayjs(),
lastUpdated: getCurrentDate(),
isInfoEditable: false,
isContractRemovable: false,
};
Expand Down
9 changes: 4 additions & 5 deletions src/lib/model/contract.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { useWallet } from "@cosmos-kit/react";
import { useQuery } from "@tanstack/react-query";
import dayjs from "dayjs";

import { useCelatoneApp } from "lib/app-provider";
import { INSTANTIATED_LIST_NAME } from "lib/data";
Expand Down Expand Up @@ -34,7 +33,7 @@ import type {
Option,
PublicInfo,
} from "lib/types";
import { formatSlugName } from "lib/utils";
import { formatSlugName, getCurrentDate, getDefaultDate } from "lib/utils";

export interface ContractData {
chainId: string;
Expand Down Expand Up @@ -68,7 +67,7 @@ export const useInstantiatedByMe = (enable: boolean): ContractListInfo => {
})),
name: INSTANTIATED_LIST_NAME,
slug: formatSlugName(INSTANTIATED_LIST_NAME),
lastUpdated: dayjs(),
lastUpdated: getCurrentDate(),
isInfoEditable: false,
isContractRemovable: false,
};
Expand All @@ -85,11 +84,11 @@ export const useInstantiatedMockInfoByMe = (): ContractListInfo => {
contractAddress: "" as ContractAddr,
instantiator: "",
label: "",
created: dayjs(0),
created: getDefaultDate(),
})),
name: INSTANTIATED_LIST_NAME,
slug: formatSlugName(INSTANTIATED_LIST_NAME),
lastUpdated: dayjs(),
lastUpdated: getCurrentDate(),
isInfoEditable: false,
isContractRemovable: false,
};
Expand Down
6 changes: 2 additions & 4 deletions src/lib/pages/home/components/RecentActivities.tsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { Flex, Heading, Box, Text, Icon } from "@chakra-ui/react";
import dayjs from "dayjs";
import { observer } from "mobx-react-lite";
import { useMemo } from "react";
import { MdSearch, MdInput } from "react-icons/md";

import { useInternalNavigate } from "lib/app-provider";
import { ExplorerLink } from "lib/components/ExplorerLink";
import { useContractStore, useUserKey } from "lib/hooks";
import { dateFromNow } from "lib/utils";

export const RecentActivities = observer(() => {
const userKey = useUserKey();
Expand Down Expand Up @@ -71,9 +71,7 @@ export const RecentActivities = observer(() => {
/>
</Flex>
<Flex gap={1}>
<Text variant="body2">
{dayjs(item.timestamp).toNow(true)} ago{" "}
</Text>
<Text variant="body2">{dateFromNow(item.timestamp)}</Text>
{/* TODO - check address as me */}
{item.sender && (
<>
Expand Down
10 changes: 5 additions & 5 deletions src/lib/pages/home/components/RecentlyViewContracts.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Heading, Box, Flex, Text } from "@chakra-ui/react";
import dayjs from "dayjs";

import { ContractListTable } from "lib/pages/contract-list/components/ContractListTable";
import type { ContractAddr } from "lib/types";
import { getCurrentDate } from "lib/utils";

/* TODO: change data -> recently view contracts */
const contracts = [
Expand All @@ -15,7 +15,7 @@ const contracts = [
description:
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque sed facilisis facilisis risus. Ut volutpat accumsan massa eget consequat, id egestas nulla.",
label: "label1",
created: dayjs(),
created: getCurrentDate(),
},
{
contractAddress:
Expand All @@ -25,7 +25,7 @@ const contracts = [
instantiator: "terra18kw0z0nmpk9drz4qxq8y7xvh05tr7spyzja3rq",
description: "Lorem ipsum dolor id egestas nulla.",
label: "label2",
created: dayjs(),
created: getCurrentDate(),
},
{
contractAddress:
Expand All @@ -35,7 +35,7 @@ const contracts = [
instantiator: "terra18kw0z0nmpk9drz4qxq8y7xvh05tr7spyzja3rq",
description: "",
label: "label3",
created: dayjs(),
created: getCurrentDate(),
},
{
contractAddress:
Expand All @@ -46,7 +46,7 @@ const contracts = [
description:
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. id egestas nulla.",
label: "label4",
created: dayjs(),
created: getCurrentDate(),
},
];
export const RecentlyViewContracts = () => {
Expand Down
5 changes: 2 additions & 3 deletions src/lib/pages/query/components/QueryArea.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { Box, Flex, Spacer, Button, ButtonGroup, Text } from "@chakra-ui/react";
import { useWallet } from "@cosmos-kit/react";
import { useQuery } from "@tanstack/react-query";
import type { AxiosError } from "axios";
import dayjs from "dayjs";
import dynamic from "next/dynamic";
import { useEffect, useState } from "react";

Expand All @@ -15,7 +14,7 @@ import { DEFAULT_RPC_ERROR } from "lib/data";
import { useContractStore, useLCDEndpoint, useUserKey } from "lib/hooks";
import { queryData } from "lib/services/contract";
import type { ContractAddr, RpcQueryError } from "lib/types";
import { encode, jsonPrettify, jsonValidate } from "lib/utils";
import { encode, getCurrentDate, jsonPrettify, jsonValidate } from "lib/utils";

const CodeSnippet = dynamic(() => import("lib/components/modal/CodeSnippet"), {
ssr: false,
Expand Down Expand Up @@ -59,7 +58,7 @@ export const QueryArea = ({
sender: address,
contractAddress,
msg: encode(msg),
timestamp: dayjs(),
timestamp: getCurrentDate(),
});
},
onError(err: AxiosError<RpcQueryError>) {
Expand Down
3 changes: 1 addition & 2 deletions src/lib/services/contract.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import axios from "axios";
import type { Dayjs } from "dayjs";
import type { GraphQLClient } from "graphql-request";

import { CELATONE_API_ENDPOINT, getChainApiPath } from "env";
Expand Down Expand Up @@ -52,7 +51,7 @@ export interface InstantiateInfo {
admin?: HumanAddr | ContractAddr;
label: string;
createdHeight: number;
createdTime: Option<Dayjs>;
createdTime: Option<Date>;
ibcPortId: string;
raw: ContractResponse;
}
Expand Down
21 changes: 10 additions & 11 deletions src/lib/stores/contract.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import type { Dayjs } from "dayjs";
import dayjs from "dayjs";
import { makeAutoObservable } from "mobx";
import { isHydrated, makePersistable } from "mobx-persist-store";

import { INSTANTIATED_LIST_NAME, SAVED_LIST_NAME } from "lib/data";
import type { LVPair, Dict, ContractAddr } from "lib/types";
import { formatSlugName, getTagsDefault } from "lib/utils";
import { formatSlugName, getCurrentDate, getTagsDefault } from "lib/utils";

export interface ContractLocalInfo {
contractAddress: ContractAddr;
Expand All @@ -21,7 +19,7 @@ interface ContractList {
name: string;
slug: string;
contracts: ContractAddr[];
lastUpdated: Dayjs;
lastUpdated: Date;
isInfoEditable: boolean;
isContractRemovable: boolean;
}
Expand All @@ -34,7 +32,8 @@ export const cmpContractListInfo = (
a: ContractListInfo,
b: ContractListInfo
) => {
if (a.lastUpdated !== b.lastUpdated) return b.lastUpdated.diff(a.lastUpdated);
if (a.lastUpdated !== b.lastUpdated)
return b.lastUpdated.getTime() - a.lastUpdated.getTime();
return a.slug.localeCompare(b.slug);
};

Expand All @@ -44,7 +43,7 @@ export interface Activity {
sender: string | undefined;
contractAddress: ContractAddr;
msg: string; // base64
timestamp: Dayjs;
timestamp: Date;
}

export class ContractStore {
Expand All @@ -55,7 +54,7 @@ export class ContractStore {
name: SAVED_LIST_NAME,
slug: formatSlugName(SAVED_LIST_NAME),
contracts: [],
lastUpdated: dayjs(),
lastUpdated: getCurrentDate(),
isInfoEditable: false,
isContractRemovable: true,
},
Expand Down Expand Up @@ -161,7 +160,7 @@ export class ContractStore {
name: name.trim(),
slug: formatSlugName(name),
contracts: [],
lastUpdated: dayjs(),
lastUpdated: getCurrentDate(),
isInfoEditable: true,
isContractRemovable: true,
},
Expand Down Expand Up @@ -193,7 +192,7 @@ export class ContractStore {

list.name = newName;
list.slug = formatSlugName(newName);
list.lastUpdated = dayjs();
list.lastUpdated = getCurrentDate();
}
}

Expand Down Expand Up @@ -333,7 +332,7 @@ export class ContractStore {
if (!list) return;

list.contracts = Array.from(new Set(list.contracts).add(contractAddress));
list.lastUpdated = dayjs();
list.lastUpdated = getCurrentDate();
}

private removeContractFromList(
Expand All @@ -347,7 +346,7 @@ export class ContractStore {
if (!list) return;

list.contracts = list.contracts.filter((addr) => addr !== contractAddress);
list.lastUpdated = dayjs();
list.lastUpdated = getCurrentDate();
}

addActivity(userKey: string, activity: Activity) {
Expand Down
6 changes: 2 additions & 4 deletions src/lib/types/code.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import type { Dayjs } from "dayjs";

import type { CodeLocalInfo } from "lib/stores/code";
import type { HumanAddr, ContractAddr, Option } from "lib/types";

Expand All @@ -24,7 +22,7 @@ export interface CodeInfo extends CodeLocalInfo {
interface CodeProposal {
proposalId: number;
height: Option<number>;
created: Dayjs;
created: Date;
}

export interface CodeData {
Expand All @@ -33,7 +31,7 @@ export interface CodeData {
uploader: ContractAddr | HumanAddr;
hash: Option<string>;
height: Option<number>;
created: Dayjs;
created: Date;
proposal: Option<CodeProposal>;
instantiatePermission: InstantiatePermission;
permissionAddresses: PermissionAddresses;
Expand Down
12 changes: 5 additions & 7 deletions src/lib/types/contract.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import type { Dayjs } from "dayjs";

import type { ContractLocalInfo } from "lib/stores/contract";
import type { ContractAddr, HumanAddr, Option } from "lib/types";

export interface ContractInfo extends ContractLocalInfo {
admin: Option<string>;
instantiated: Dayjs;
instantiated: Date;
latestUpdator: Option<string>;
latestUpdated: Dayjs;
latestUpdated: Date;
}

export interface ContractInstances {
Expand All @@ -34,7 +32,7 @@ export interface ContractMigrationHistory {
codeDescription?: string;
sender: HumanAddr | ContractAddr;
height: number;
timestamp: Dayjs;
timestamp: Date;
remark: MigrationRemark;
}

Expand All @@ -60,8 +58,8 @@ export interface ContractRelatedProposals {
proposalId: number;
title: string;
status: ProposalStatus;
votingEndTime: Dayjs;
depositEndTime: Dayjs;
votingEndTime: Date;
depositEndTime: Date;
resolvedHeight: number | null | undefined;
type: ProposalType;
proposer: HumanAddr | ContractAddr | undefined;
Expand Down
Loading