Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change code description to code name, wireup public code name in code detail #174

Merged
merged 5 commits into from
Feb 8, 2023
Merged

fix: change code description to code name, wireup public code name in code detail #174

merged 5 commits into from
Feb 8, 2023

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Feb 8, 2023 •
edited
Loading

Describe your changes

  • Change code description to code name
  • Wireup code detail page for public project. Will currently show :
    user saved name -> public code name -> code id
    logo of the project

@vercel
Copy link

vercel bot commented Feb 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
beeb-celatone-frontend 🔄 Building (Inspect) Feb 8, 2023 at 9:16AM (UTC)
celatone-demo-terra ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 9:16AM (UTC)
celatone-frontend-initial-demo 🔄 Building (Inspect) Feb 8, 2023 at 9:16AM (UTC)
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 9:16AM (UTC)
terra-celatone-frontend 🔄 Building (Inspect) Feb 8, 2023 at 9:16AM (UTC)
terra-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 9:16AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Feb 8, 2023 at 9:16AM (UTC)

evilpeach
evilpeach requested changes Feb 8, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/lib/services/publicProjectService.ts Show resolved Hide resolved
src/lib/components/modal/code/SaveNewCode.tsx Outdated Show resolved Hide resolved
src/lib/pages/public-project/components/BookmarkButton.tsx Outdated Show resolved Hide resolved
src/lib/pages/public-project/components/DetailHeader.tsx Outdated Show resolved Hide resolved
@bkioshn bkioshn merged commit 3a5be82 into develop Feb 8, 2023
@bkioshn bkioshn deleted the fix/code-name branch February 8, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@songwongtp songwongtp Awaiting requested review from songwongtp

@poomthiti poomthiti Awaiting requested review from poomthiti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bkioshn @evilpeach