Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): init setup icon #216

Merged
merged 20 commits into from
Mar 8, 2023
Merged

feat(components): init setup icon #216

merged 20 commits into from
Mar 8, 2023

Conversation

jennieramida
Copy link
Collaborator

@jennieramida jennieramida commented Feb 21, 2023 •
edited by evilpeach
Loading

Describe your changes

  • apply new icons all the place.

@vercel
Copy link

vercel bot commented Feb 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
celatone-demo-terra ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 3:10PM (UTC)
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 3:10PM (UTC)
terra-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 3:10PM (UTC)
4 Ignored Deployments
Name Status Preview Comments Updated
beeb-celatone-frontend ⬜️ Ignored (Inspect) Mar 8, 2023 at 3:10PM (UTC)
celatone-frontend-initial-demo ⬜️ Ignored (Inspect) Mar 8, 2023 at 3:10PM (UTC)
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Mar 8, 2023 at 3:10PM (UTC)
terra-celatone-frontend ⬜️ Ignored (Inspect) Mar 8, 2023 at 3:10PM (UTC)

evilpeach
evilpeach requested changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@evilpeach evilpeach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on 'constant.ts'. Please delete 'keyof typeof ICONS' in every places and use 'IconKeys' instead.

CHANGELOG.md Outdated Show resolved Hide resolved
src/lib/components/ListSelection.tsx Outdated Show resolved Hide resolved
src/lib/components/icon/CustomIcon.tsx Outdated Show resolved Hide resolved
src/lib/data/constant.ts Outdated Show resolved Hide resolved
src/lib/pages/public-project/components/SocialMedia.tsx Outdated Show resolved Hide resolved
traviolus
traviolus requested changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@traviolus traviolus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public contract info appears on the top left of the screen like this

Screenshot 2023-03-08 at 4 43 14 PM

traviolus
traviolus requested changes Mar 8, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
evilpeach
evilpeach requested changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@evilpeach evilpeach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Create index.ts that export CustomIcon and UploadIcon on lib/components/icon folder.
  2. Replace all from import ... from "lib/components/icon/CustomIcon"; to this import ... from "lib/components/icon";

src/lib/components/button/index.ts Show resolved Hide resolved
src/lib/pages/public-project/components/SocialMedia.tsx Outdated Show resolved Hide resolved
src/lib/components/json/JsonInput.tsx Outdated Show resolved Hide resolved
src/lib/components/json/JsonInput.tsx Outdated Show resolved Hide resolved
@evilpeach evilpeach dismissed songwongtp’s stale review March 8, 2023 15:12

I've already reviewed this

@evilpeach evilpeach merged commit 78a7f34 into develop Mar 8, 2023
@evilpeach evilpeach deleted the fix/replace-icons branch March 8, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@traviolus traviolus traviolus approved these changes

@bkioshn bkioshn Awaiting requested review from bkioshn

@poomthiti poomthiti Awaiting requested review from poomthiti

@songwongtp songwongtp Awaiting requested review from songwongtp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jennieramida @evilpeach @songwongtp @traviolus