Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: table drawers #240

Merged
merged 6 commits into from
Mar 20, 2023
Merged

feat: table drawers #240

merged 6 commits into from
Mar 20, 2023

Conversation

songwongtp
Copy link
Collaborator

Describe your changes

  • table drawer for contract selection - query/execute and migrate
  • for code selection - deploy, migrate, and update admin

Demo Link

@vercel
Copy link

vercel bot commented Mar 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
celatone-demo-terra ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 20, 2023 at 3:51AM (UTC)
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 20, 2023 at 3:51AM (UTC)
terra-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 20, 2023 at 3:51AM (UTC)
4 Ignored Deployments
Name Status Preview Comments Updated
beeb-celatone-frontend ⬜️ Ignored (Inspect) Mar 20, 2023 at 3:51AM (UTC)
celatone-frontend-initial-demo ⬜️ Ignored (Inspect) Mar 20, 2023 at 3:51AM (UTC)
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Mar 20, 2023 at 3:51AM (UTC)
terra-celatone-frontend ⬜️ Ignored (Inspect) Mar 20, 2023 at 3:51AM (UTC)

bkioshn
bkioshn suggested changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add ml="1px" to CustomIcon in EditableCell
  • Implement disable list when list contains 0 contracts

@songwongtp
Copy link
Collaborator Author

  • add ml="1px" to CustomIcon in EditableCell
  • Implement disable list when list contains 0 contracts

fixed

@songwongtp songwongtp requested a review from bkioshn March 17, 2023 03:31
evilpeach
evilpeach requested changes Mar 17, 2023
View reviewed changes
src/lib/styles/theme/components/drawer.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
evilpeach
evilpeach approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@songwongtp songwongtp merged commit bfbd634 into develop Mar 20, 2023
@songwongtp songwongtp deleted the feat/table-drawers branch March 20, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@bkioshn bkioshn bkioshn approved these changes

@poomthiti poomthiti Awaiting requested review from poomthiti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@songwongtp @evilpeach @bkioshn