Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): Json viewer and view more btn #243

Merged
merged 5 commits into from
Mar 16, 2023
Merged

fix(components): Json viewer and view more btn #243

merged 5 commits into from
Mar 16, 2023

Conversation

evilpeach
Copy link
Collaborator

@evilpeach evilpeach commented Mar 16, 2023 •
edited
Loading

Describe your changes

  • fix "View more button" mechanism
  • JsonInput' and 'JsonReadOnly' components have been improved to limit the display line.

@vercel
Copy link

vercel bot commented Mar 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
celatone-demo-terra ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 9:55AM (UTC)
celatone-frontend-initial-demo 🔄 Building (Inspect) Mar 16, 2023 at 9:55AM (UTC)
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 9:55AM (UTC)
terra-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 9:55AM (UTC)
3 Ignored Deployments
Name Status Preview Comments Updated
beeb-celatone-frontend ⬜️ Ignored (Inspect) Mar 16, 2023 at 9:55AM (UTC)
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Mar 16, 2023 at 9:55AM (UTC)
terra-celatone-frontend ⬜️ Ignored (Inspect) Mar 16, 2023 at 9:55AM (UTC)

poomthiti
poomthiti suggested changes Mar 16, 2023
View reviewed changes
src/lib/components/json/JsonInput.tsx Outdated Show resolved Hide resolved
src/lib/pages/query/components/QueryArea.tsx Outdated Show resolved Hide resolved
src/lib/components/json/JsonInput.tsx Show resolved Hide resolved
src/lib/components/json/JsonReadOnly.tsx Outdated Show resolved Hide resolved
@evilpeach evilpeach merged commit d83ca57 into develop Mar 16, 2023
@evilpeach evilpeach deleted the fix/view-more-mecha branch March 16, 2023 10:11
@evilpeach evilpeach added the bug Something isn't working label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poomthiti poomthiti poomthiti approved these changes

@songwongtp songwongtp Awaiting requested review from songwongtp

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evilpeach @poomthiti