Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pool header and pool assets for pool details page #296

Merged
merged 2 commits into from
May 9, 2023
Merged

feat: pool header and pool assets for pool details page #296

merged 2 commits into from
May 9, 2023

Conversation

poomthiti
Copy link
Contributor

Describe your changes

Demo Link

@vercel
Copy link

vercel bot commented Apr 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-demo-terra ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 9:51am
celatone-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 9:51am
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 9:51am
terra-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 9:51am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
beeb-celatone-frontend ⬜️ Ignored (Inspect) May 9, 2023 9:51am
celatone-frontend-initial-demo ⬜️ Ignored (Inspect) May 9, 2023 9:51am
mitosis-celatone-frontend-staging ⬜️ Ignored (Inspect) May 9, 2023 9:51am
neutron-celatone-frontend-staging ⬜️ Ignored (Inspect) May 9, 2023 9:51am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) May 9, 2023 9:51am
sei-celatone-frontend-staging ⬜️ Ignored (Inspect) May 9, 2023 9:51am
stargaze-celatone-frontend-staging ⬜️ Ignored (Inspect) Visit Preview May 9, 2023 9:51am
terra-celatone-frontend ⬜️ Ignored (Inspect) May 9, 2023 9:51am

evilpeach
evilpeach requested changes May 9, 2023
View reviewed changes
src/lib/pages/pools/components/pool-details/header/PoolHeader.tsx Outdated Show resolved Hide resolved
src/lib/pages/pools/components/PoolDetailHeader.tsx Outdated Show resolved Hide resolved
src/lib/pages/pools/components/PoolDetailHeader.tsx Outdated Show resolved Hide resolved
src/lib/pages/pools/components/pool-details/pool-assets/table/PoolAssetsTableRow.tsx Outdated Show resolved Hide resolved
src/lib/pages/pools/components/pool-details/pool-assets/table/PoolAssetsTableRow.tsx Outdated Show resolved Hide resolved
src/lib/pages/pools/components/pool-details/pool-assets/table/PoolAssetsTableRow.tsx Outdated Show resolved Hide resolved
src/lib/pages/pools/components/pool-details/pool-assets/table/PoolAssetsTableRow.tsx Outdated Show resolved Hide resolved
src/lib/pages/pools/components/supportedSection/AllocationBadge.tsx Outdated Show resolved Hide resolved
src/lib/utils/formatter/percentage.ts Outdated Show resolved Hide resolved
src/lib/components/CopyLink.tsx Outdated Show resolved Hide resolved
@poomthiti poomthiti requested a review from evilpeach May 9, 2023 09:45
evilpeach
evilpeach approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@poomthiti poomthiti merged commit da39b51 into pages/pool-list May 9, 2023
1 check passed
@poomthiti poomthiti deleted the feat/pool-details branch May 9, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@songwongtp songwongtp Awaiting requested review from songwongtp

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poomthiti @evilpeach @bkioshn