fix: permissioned upload condition #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
evilpeach
reviewed
May 12, 2023
poomthiti
approved these changes
May 15, 2023
evilpeach
changed the title
evilpeach
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Previously, the condition that Celatone uses to check whether to disable uploading codes to a network is whether the network is mainnet. This works in the case of Osmosis. However, as we start to support other networks, this condition no longer apply.
Instead, this PR changes the condition to checking the wasm module's
code_upload_accesspermissionfield using the current network's LCD. If the field value is "Everybody", we will allow the user to upload code on the network, and no otherwise