Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/contract list #42

Merged
merged 8 commits into from
Dec 29, 2022
Merged

Refactor/contract list #42

merged 8 commits into from
Dec 29, 2022

Conversation

poomthiti
Copy link
Contributor

@poomthiti poomthiti commented Dec 22, 2022 •
edited
Loading

Describe your changes

  • Refactor contract list table code
  • Remove 'Deploy new contract' from 'Saved List' and' created list
  • Fix Instantiated by me: contract list still exists when disconnected
  • Remove 'Save Contract' from 'Instiantiated by me'

Demo Link

https://celatone-frontend-staging-git-refactor-contract-list-alles-labs.vercel.app/contract-list

@vercel
Copy link

vercel bot commented Dec 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
celatone-frontend ✅ Ready (Inspect) Visit Preview ✅ 1 resolved Dec 29, 2022 at 5:18AM (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview ✅ 1 resolved Dec 29, 2022 at 5:18AM (UTC)

@poomthiti poomthiti changed the base branch from main to develop December 23, 2022 11:26
evilpeach
evilpeach requested changes Dec 27, 2022
View reviewed changes
src/pages/contract-list/index.tsx Outdated Show resolved Hide resolved
src/pages/contract-list/[slug].tsx Outdated Show resolved Hide resolved
src/lib/stores/contract.ts Outdated Show resolved Hide resolved
evilpeach
evilpeach requested changes Dec 27, 2022
View reviewed changes
src/lib/components/modal/select-contract/ListCard.tsx Outdated Show resolved Hide resolved
src/lib/pages/contracts/components/ContractListTable.tsx Outdated Show resolved Hide resolved
src/lib/components/modal/select-contract/AllContractLists.tsx Show resolved Hide resolved
src/lib/components/modal/select-contract/ListCard.tsx Outdated Show resolved Hide resolved
src/lib/pages/contracts/slug.tsx Outdated Show resolved Hide resolved
src/lib/components/state/ZeroState.tsx Show resolved Hide resolved
src/lib/components/modal/select-contract/ListDetail.tsx Outdated Show resolved Hide resolved
src/lib/components/modal/select-contract/ListDetail.tsx Outdated Show resolved Hide resolved
src/lib/components/modal/select-contract/ListDetail.tsx Outdated Show resolved Hide resolved
@poomthiti poomthiti merged commit d1673dd into develop Dec 29, 2022
@poomthiti poomthiti deleted the refactor/contract-list branch December 29, 2022 05:33
poomthiti added a commit that referenced this pull request Dec 29, 2022
@poomthiti
Merge pull request #52 from alleslabs/feat/disconnected-state
a6cd2c8 
feat: add disconnected state [Merge #42 first]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@songwongtp songwongtp songwongtp approved these changes

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poomthiti @evilpeach @songwongtp