Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement merge navigation #436

Merged
merged 24 commits into from
Jul 14, 2023
Merged

feat: implement merge navigation #436

merged 24 commits into from
Jul 14, 2023

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jul 13, 2023 •
edited
Loading

Describe your changes

Implement merge navigation
Dev mode

  • Containing 4 sections Your Account, Quick Actions, This device, Public Project (if exist)
  • If user is currently in basic mode and switch to dev mode and sidebar is collapsed -> expand the sidebar

Basic mode

  • Containing 3 sections Your Account, This Device, Public Project (if exist)
  • If user is currently in dev mode and switch to basic mode and sidebar is expanded -> collapse the sidebar

Notes

  • Disable Wasm features should not show Wasm related feature on the sidebar and top bar
  • When user reenter the website the sidebar expand and collapse state should persist

@vercel
Copy link

vercel bot commented Jul 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 11:25am
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 11:25am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
neutron-celatone-frontend ⬜️ Ignored (Inspect) Jul 14, 2023 11:25am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Jul 14, 2023 11:25am
sei-celatone-frontend ⬜️ Ignored (Inspect) Jul 14, 2023 11:25am
sei-testnet-celatone-frontend ⬜️ Ignored (Inspect) Jul 14, 2023 11:25am
stargaze-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 14, 2023 11:25am

@bkioshn bkioshn marked this pull request as draft July 13, 2023 06:49
evilpeach
evilpeach requested changes Jul 13, 2023
View reviewed changes
src/lib/layout/index.tsx Outdated Show resolved Hide resolved
src/lib/layout/navbar/index.tsx Outdated Show resolved Hide resolved
src/lib/layout/navbar/index.tsx Outdated Show resolved Hide resolved
@evilpeach evilpeach merged commit 562111e into develop Jul 14, 2023
13 checks passed
@evilpeach evilpeach deleted the feat/merge-navigation branch July 14, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkioshn @evilpeach @poomthiti