Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saved account type check #625

Merged
merged 4 commits into from
Nov 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Improvements

- [#625](https://github.com/alleslabs/celatone-frontend/pull/625) Fix abi empty vector serialization
- [#605](https://github.com/alleslabs/celatone-frontend/pull/605) Apply singleton class style to Amplitude structure
- [#591](https://github.com/alleslabs/celatone-frontend/pull/591) Bump initia.js due to decimal serialization and dynamic buffer
- [#564](https://github.com/alleslabs/celatone-frontend/pull/564) Handle multi bond denoms data in the delegation section
Expand Down
1 change: 1 addition & 0 deletions src/lib/app-provider/env.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export enum CELATONE_QUERY_KEYS {
// ACCOUNT
ACCOUNT_BALANCES_INFO = "CELATONE_QUERY_ACCOUNT_BALANCES_INFO",
ACCOUNT_ID = "CELATONE_QUERY_ACCOUNT_ID",
ACCOUNT_TYPE = "CELATONE_QUERY_ACCOUNT_TYPE",
// ASSET
ASSET_INFOS = "CELATONE_QUERY_ASSET_INFOS",
ASSET_INFO_LIST = "CELATONE_QUERY_ASSET_INFO_LIST",
Expand Down
90 changes: 49 additions & 41 deletions src/lib/app-provider/hooks/useAddress.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import { fromBech32 } from "@cosmjs/encoding";
import { useCallback, useMemo } from "react";

import type { Option } from "lib/types";
import { isHexWalletAddress, isHexModuleAddress } from "lib/utils";
import { isHexModuleAddress, isHexWalletAddress } from "lib/utils";

import { useMoveConfig } from "./useConfig";
import { useCurrentChain } from "./useCurrentChain";
import { useExampleAddresses } from "./useExampleAddresses";

Expand Down Expand Up @@ -97,53 +98,60 @@ export const useGetAddressType = () => {
);
};

// TODO: refactor
export const useValidateAddress = () => {
const {
chain: { bech32_prefix: bech32Prefix },
} = useCurrentChain();
const getAddressTypeByLength = useGetAddressTypeByLength();
const move = useMoveConfig({ shouldRedirect: false });

const validateContractAddress = useCallback(
(address: string) =>
validateAddress(
bech32Prefix,
address,
"contract_address",
getAddressTypeByLength
),
[bech32Prefix, getAddressTypeByLength]
);
const validateUserAddress = useCallback(
(address: string) =>
validateAddress(
bech32Prefix,
address,
"user_address",
getAddressTypeByLength
),
[bech32Prefix, getAddressTypeByLength]
);
const validateValidatorAddress = useCallback(
(address: string) =>
validateAddress(
bech32Prefix,
address,
"validator_address",
getAddressTypeByLength
),
[bech32Prefix, getAddressTypeByLength]
);

return {
validateContractAddress: useCallback(
(address: string) =>
validateAddress(
bech32Prefix,
address,
"contract_address",
getAddressTypeByLength
),
[bech32Prefix, getAddressTypeByLength]
),
validateUserAddress: useCallback(
(address: string) =>
validateAddress(
bech32Prefix,
address,
"user_address",
getAddressTypeByLength
),
[bech32Prefix, getAddressTypeByLength]
),
validateValidatorAddress: useCallback(
(address: string) =>
validateAddress(
bech32Prefix,
address,
"validator_address",
getAddressTypeByLength
),
[bech32Prefix, getAddressTypeByLength]
),
validateHexWalletAddress: useCallback(
(address: string) =>
!address.startsWith(bech32Prefix) && isHexWalletAddress(address),
[bech32Prefix]
),
validateHexModuleAddress: useCallback(
(address: string) =>
!address.startsWith(bech32Prefix) && isHexModuleAddress(address),
[bech32Prefix]
validateContractAddress,
validateUserAddress,
validateValidatorAddress,
isSomeValidAddress: useCallback(
(address: string) => {
const errUser = validateUserAddress(address);
const errContract = validateContractAddress(address);
const isHex = isHexWalletAddress(address);
const isHexModule = isHexModuleAddress(address);

return (
!errUser || !errContract || (move.enabled && (isHex || isHexModule))
);
},
[move.enabled, validateContractAddress, validateUserAddress]
),
};
};
24 changes: 7 additions & 17 deletions src/lib/components/abi/args-form/field/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { type Control, useController } from "react-hook-form";

import { useValidateAddress } from "lib/app-provider";
import type { AbiFormData } from "lib/types";
import { isHexModuleAddress, isHexWalletAddress } from "lib/utils";

import { ArgFieldWidget } from "./ArgFieldWidget";
import { OBJECT_TYPE, STRING_TYPE } from "./constants";
Expand All @@ -30,31 +31,20 @@ export const ArgFieldTemplate = ({
control,
}: ArgFieldTemplateProps) => {
const [isEditted, setIsEditted] = useState(false);
const {
validateUserAddress,
validateContractAddress,
validateHexWalletAddress,
validateHexModuleAddress,
} = useValidateAddress();
const { validateUserAddress, validateContractAddress } = useValidateAddress();

const isValidArgAddress = useCallback(
(input: string) =>
validateUserAddress(input) === null ||
validateContractAddress(input) === null ||
validateHexWalletAddress(input) ||
validateHexModuleAddress(input),
[
validateContractAddress,
validateHexModuleAddress,
validateHexWalletAddress,
validateUserAddress,
]
isHexWalletAddress(input) ||
isHexModuleAddress(input),
[validateContractAddress, validateUserAddress]
);
const isValidArgObject = useCallback(
(input: string) =>
validateContractAddress(input) === null ||
validateHexModuleAddress(input),
[validateContractAddress, validateHexModuleAddress]
validateContractAddress(input) === null || isHexModuleAddress(input),
[validateContractAddress]
);

const isOptional = param.startsWith("0x1::option::Option");
Expand Down
4 changes: 4 additions & 0 deletions src/lib/components/forms/ControllerInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ export const ControllerInput = <T extends FieldValues>({
rules = {},
status,
maxLength,
autoFocus,
cursor,
helperAction,
...componentProps
}: ControllerInputProps<T>) => {
Expand Down Expand Up @@ -94,6 +96,8 @@ export const ControllerInput = <T extends FieldValues>({
value={watcher}
onChange={field.onChange}
maxLength={maxLength}
autoFocus={autoFocus}
cursor={cursor}
/>
<InputRightElement h="full">
{status && getStatusIcon(status.state)}
Expand Down
1 change: 1 addition & 0 deletions src/lib/components/modal/account/EditSavedAccount.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export const EditSavedAccountModal = ({
error={
errors.name && getMaxLengthError(nameState.length, "account_name")
}
autoFocus
/>
<ControllerTextarea
name="description"
Expand Down
Loading
Loading