Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFE-309]: Refactor(pages): refactor module details service files #899

Merged
merged 14 commits into from
Apr 30, 2024

Conversation

Poafs1
Copy link
Collaborator

@Poafs1 Poafs1 commented Apr 27, 2024

NOTE: New Module Info UI NOT Included in the PR. Will update it in next PR accordingly.

Copy link

linear bot commented Apr 27, 2024

Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 10:28am
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
celatone-frontend-main ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 10:28am
initia-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 10:28am
initia-testnet-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 10:28am
neutron-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 10:28am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 10:28am
sei-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 10:28am
terra-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 10:28am

src/lib/services/move/module.ts Fixed Show fixed Hide fixed
src/lib/services/move/module.ts Fixed Show fixed Hide fixed
src/lib/services/move/module.ts Fixed Show fixed Hide fixed
src/lib/services/move/module.ts Fixed Show fixed Hide fixed
src/lib/app-provider/env.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Rename address to vmAddress
  2. Swap order vmAddress and moduleName (vmAddress comes first)
  3. Swap order limit and offset (limit comes first)

src/lib/services/move/module.ts Outdated Show resolved Hide resolved
src/lib/services/move/module.ts Outdated Show resolved Hide resolved
src/lib/services/move/module.ts Outdated Show resolved Hide resolved
src/lib/services/move/module.ts Outdated Show resolved Hide resolved
src/lib/services/move/module.ts Outdated Show resolved Hide resolved
src/lib/pages/module-details/index.tsx Outdated Show resolved Hide resolved
src/lib/pages/module-details/index.tsx Outdated Show resolved Hide resolved
src/lib/pages/module-details/index.tsx Outdated Show resolved Hide resolved
src/lib/pages/module-details/components/ModuleInfoBody.tsx Outdated Show resolved Hide resolved
@Poafs1 Poafs1 merged commit be8ec1c into develop Apr 30, 2024
14 checks passed
@Poafs1 Poafs1 deleted the feature/cfe-309-module-details branch April 30, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants