Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CFE-524] Fix - asset selection bug #944

Merged
merged 7 commits into from
Jun 19, 2024
Merged

[CFE-524] Fix - asset selection bug #944

merged 7 commits into from
Jun 19, 2024
+9 −6

Conversation

evilpeach
Copy link
Collaborator

  • Can't select attach funds
  • When adding more assets, a selected asset has gone.

@vercel Vercel
Copy link

vercel bot commented May 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 9:48am
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
celatone-frontend-main ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 9:48am
initia-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 9:48am
initia-testnet-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 9:48am
neutron-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 9:48am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 9:48am
sei-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 9:48am
terra-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 9:48am

@evilpeach evilpeach changed the title fix: asset input bug fix: asset selection bug May 27, 2024
Poafs1
Poafs1 approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@Poafs1 Poafs1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can wait for @songwongtp to approve as well.

@evilpeach evilpeach requested a review from Poafs1 May 28, 2024 04:17
songwongtp
songwongtp requested changes May 28, 2024
View reviewed changes
src/lib/components/fund/selectFund.tsx Outdated Show resolved Hide resolved
src/lib/components/fund/selectFund.tsx Outdated Show resolved Hide resolved
@Poafs1 Poafs1 changed the title fix: asset selection bug [CFE-524] Fix - asset selection bug Jun 18, 2024
@linear Linear
Copy link

linear bot commented Jun 18, 2024

CFE-524 [BUG] Asset Selection

@Poafs1 Poafs1 requested a review from songwongtp June 18, 2024 10:09
Poafs1
Poafs1 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@Poafs1 Poafs1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evilpeach evilpeach merged commit 89c8817 into develop Jun 19, 2024
14 checks passed
@evilpeach evilpeach deleted the fix/asset-input branch June 19, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songwongtp songwongtp songwongtp approved these changes

@Poafs1 Poafs1 Poafs1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evilpeach @songwongtp @Poafs1