-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cert-handler #8
Comments
Resolved the problem. Others arise:
|
@rtsh The browser parameter is missing in upstream CEF. It was added only recently in branch 2272 revision 2029: https://code.google.com/p/chromiumembedded/issues/detail?id=1530 |
@CzarekTomczak I wonder if it would be possible to pass the browser instance to the ClientHandler here: https://code.google.com/p/cefpython/source/browse/cefpython/cefpython.pyx#392 |
@rtsh The problem is that we can assign browser instance to client handler only after browser was created. Currently only synchronous browser creation is available. So it's probably not possible to have the browser parameter available during initial browser navigation. However to be sure about that one would need to run tests. You could edit ClientHandler C++ code and add browserIdentifier_ property. Set it in cefpython.pyx you refered to. And then pass it to and check in RequestHandler_OnCertificateError() whether GetPyBrowserById() returns not empty value. Even if this doesn't work, it can still work assuming that the initial url during browser creation is guaranteed to not have a certificate error (about:blank or data:text/html;base64, for example). Browser id would be available for all subsequent browser navigations. |
In CEF 51 the browser object is now passed to OnCertificateError - but it needs updating cefpython bindings to expose it to python. |
CEFBrowser.certificate_error_handler;
TypeError: unbound method must be called with CEFBrowser instance as first argument (got int instance instead)
The text was updated successfully, but these errors were encountered: