Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cefpython3 version 66 adoptions #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rnixx
Copy link

@rnixx rnixx commented Feb 1, 2019

Just tested with python 3.5.3 on linux with kivy 1.10.1 and cefpython3 66.0.
Have not run all examples yet, just the minimal one, this is what i encountered so far.

  • Sort imports.
  • Some PEP8.
  • Check for __kivy__activeKeyboardElement before accessing in CEFBrowser._on_focus.
  • Check for keyboard_widget in keyboard_position_simple and keyboard_position_optimal before accessing.
  • Adopt OnConsoleMessage signature.
  • Adopt OnBeforeBrowse signature.

…re accessing in CEFBrowser._on_focus. Check for keyboard_widget in keyboard_position_simple and keyboard_position_optimal before accessing. Adopt OnConsoleMessage signature. Adopt OnBeforeBrowse signature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant