Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add deployignore #1147

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Re-add deployignore #1147

merged 3 commits into from
Jul 2, 2024

Conversation

kevinfodness
Copy link
Member

Temporarily re-adds the .deployignore file so that the GitHub Actions workflow for deploying to WordPress.org exists in the develop-built branch so that we can manually trigger a deploy. I will file an issue for the future to remove the deployignore file and retool the way we are handling deploys to wp.org to remove the built branch workflow entirely, so that the assets are built and the deploy happens all within the same workflow and we aren't committing built assets at all.

Copy link
Member

@benpbolton benpbolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wouldn't mind a

# Notably must include .github for tag push workfow
# .github

in here so it doesn't bite the next dev, but fine as-is!

@kevinfodness kevinfodness merged commit 939380b into develop Jul 2, 2024
8 checks passed
@kevinfodness kevinfodness deleted the fix/deploys branch July 2, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants