AN-55 Fix for widescreen text width #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 29, 2016 16:43
…ds and PHP best practices.
…ace on non-centered layouts.
jakewrfoster
approved these changes
Dec 30, 2016
| protected function content_nodes() { | ||
| return $this->content->nodes(); | ||
| protected function content_title() { | ||
| return $this->content->title() ?: __( 'Untitled Article', 'apple-news' ); |
There was a problem hiding this comment.
Not sure this is a valid concern, but seeing that WP is backward compat to php 5.2.x, this might be an issue (though highly unlikely). Support for this shorthand syntax for ternary operations was introduced in 5.3.
Not sure this is a risk, just thought I'd flag it since this is a plugin.
| */ | ||
| protected function get_setting( $name ) { | ||
| return $this->settings->get( $name ); | ||
| protected function set_content_property( $name, $value ) { |
There was a problem hiding this comment.
missing @param for these guys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233.