AN-54 Addition of basic HTML support #270
Conversation
…tter framework for indicating component support.
| @@ -288,6 +288,28 @@ function __construct( $page ) { | |||
| 'label' => __( 'Pull quote transformation', 'apple-news' ), | |||
| 'type' => array( 'none', 'uppercase' ), | |||
| ), | |||
| 'monospaced_font' => array( | |||
| 'label' => '', | |||
There was a problem hiding this comment.
Yeah, that's the convention for the font dropdown on all fields that have fonts. It's a good point, though. I'll add it in.
| 'tracking' => intval( $this->get_setting( 'monospaced_tracking' ) ) / 100, | ||
| 'lineHeight' => intval( $this->get_setting( 'monospaced_line_height' ) ), | ||
| 'textColor' => $this->get_setting( 'monospaced_color' ), | ||
| 'paragraphSpacingBefore' => 18, |
There was a problem hiding this comment.
where does this come from? should it be a setting? (same with the line below)
There was a problem hiding this comment.
This may be moved to a setting at some point in the future. We're discussing adding additional customization options.
| @@ -0,0 +1,123 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Please check tabbing between the various php files, some seem to have spaces, some tabs, might just be how it looks in github, /shrug
There was a problem hiding this comment.
There is an open issue for moving everything to WP standards, so this is on the roadmap. I'm trying to refactor as I go, but if I'm only applying minor changes to a file, I won't refactor the entire thing.
| case 'em': | ||
| return $this->_parse_node_emphasis( $node ); | ||
| case 'br': | ||
| return ' ' . "\n"; |
There was a problem hiding this comment.
This was in the code previously (I just refactored it) so I believe it is necessary, but can check.
| private function parse_text_node( $node ) { | ||
| return str_replace( '!', '\\!', $node->nodeValue ); | ||
| private function _parse_node_emphasis( $node ) { | ||
| return '_' . $this->parse_nodes( $node->childNodes ) . '_'; |
There was a problem hiding this comment.
there must be something magical about the underscores I dont undestand 🤔
There was a problem hiding this comment.
It's converting to markdown, so <em>text</em> becomes _text_.
|
|
||
| return sprintf( | ||
| '%s %s' . "\n", | ||
| str_repeat( '#', $matches[1] ), |
There was a problem hiding this comment.
This point in the code is never reached unless an explicit match was already found, so $matches[1] will never be empty. However, your comment made me think about the fact that a preg_match is overkill for what we're doing here, so I can convert to a substr.
|
|
||
| return "- " . $this->parse_nodes( $node->childNodes ); | ||
| private function _parse_node_text( $node ) { | ||
| return str_replace( '!', '\\!', $node->nodeValue ); |
There was a problem hiding this comment.
double slashes, what is this foreign language i dont understand?
| * @access public | ||
| */ | ||
| public function __construct( $format = 'markdown' ) { | ||
| $this->format = ( $format === 'html' ) ? 'html' : 'markdown'; |
| libxml_use_internal_errors( false ); | ||
|
|
||
| // Find the first-level nodes of the body tag. | ||
| $nodes = $dom->getElementsByTagName( 'body' )->item( 0 )->childNodes; |
There was a problem hiding this comment.
dumb question, but can you assume 'body' exists?
There was a problem hiding this comment.
Yeah, in a DOMDocument context, it will always exist.
| @@ -92,7 +92,7 @@ public function write_json( $content ) { | |||
| // JSON should be decoded before being stored. | |||
| // Otherwise, stripslashes_deep could potentially remove valid characters | |||
| // such as newlines (\n).s | |||
| $decoded_json = json_decode( sanitize_text_field( $json ) ); | |||
| $decoded_json = json_decode( $json ); | |||
There was a problem hiding this comment.
dunno why this is changing, but just make sure you wanna do this:)
There was a problem hiding this comment.
It's changing because we're adding support for HTML, so if you run sanitize_text_field on JSON that contains HTML it hoses it. The HTML output is being run through wp_kses with a strict set of tag and attribute restrictions.
<pre>tags.Fixes #222.
Fixes #232.