This repository has been archived by the owner on Apr 17, 2024. It is now read-only.
Send notifications to DM instead of code review channels #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpbolton
reviewed
Nov 30, 2021
| @@ -676,6 +677,7 @@ class CodeReviews | |||
| newStatus = false | |||
| message = "Hey @#{cr.user.name}, looks like *#{cr.slug}* was closed on GitHub." + | |||
| " Say `ignore #{cr.slug}` to remove it from the queue." | |||
There was a problem hiding this comment.
Since every room can have it's own code review queue... and this message used to appear in-channel to identify which queue/channel, it seems like we might want to append the channel name to this message in some manner
benpbolton
suggested changes
Dec 22, 2021
benpbolton
approved these changes
Dec 22, 2021
I agree, I'd started work on this and subsequently got swamped by end of year client work. Thanks for picking this up, I think this is a huge win for developer experience in code review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something we had discussed in Tech CoP Planning was removing the alert that is sent to #codereview when changes are requested. This PR is an attempt at starting that process.
Reasoning
What this PR does is remove all public messages to the channel, instead directing the generic message to the correct recipient--either the reviewer, or the submitter. The reasoning for this is simple: They were already the intended recipient of the message. The message they receive asks them to perform optional tasks, which are unlikely to be performed by anybody else on staff even if they do happen to see the message.
Due to this, it is my belief that very little will change in workflow with this change, except the removal of what can sometimes feel like an unintentional public shaming when we request changes. The hope is that this will lead to reviewers feeling more comfortable with using this option.