Reduce use of inner validators #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogmarsh
approved these changes
Nov 1, 2023
| if (! $valid) { | ||
| $messages = $this->validDivisors->getMessages(); | ||
| throw new InvalidArgumentException("Invalid 'divisor': " . current($messages)); | ||
| if ($divisor === 0) { |
There was a problem hiding this comment.
do we need to check if the divisor is an int as well? Or is that handled somewhere else?
There was a problem hiding this comment.
The divisor can also be a float or a string or whatever else PHP can convert to an integer. I'm kinda inclined to not get in the way of that. Also, I don't want to introduce a restriction with this change that would require a major version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Profiling conducted on a recent client project suggests the use of validators within validators becomes relatively slow. This PR removes the use of these inner validators, which makes the code less DRY but should make it more performant.
Since most of the slowdown caused by the inner validators occurred during processing by the abstract validator class, it might be worth considering moving this library's validators away from that abstract validator, making it more palatable to use inner validators again.
Notes for reviewers
None.
Changelog entries
Added
Changed
Deprecated
Removed
Fixed
Security