Fixing ddSql method (#549)

* Fixing ddSql method * Ensure the script does die
alleyinteractive · May 9, 2024 · e5b69fa · e5b69fa
1 parent f297f2d
commit e5b69fa
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/mantle/database/query/class-builder.php b/src/mantle/database/query/class-builder.php
@@ -151,7 +151,7 @@ abstract public function dumpSql(): static;
 	/**
 	 * Dump the SQL query for the request and stop execution.
 	 */
-	abstract public function ddSql(): void;
+	abstract public function ddSql(): never;
 
 	/**
 	 * Get a model instance for the builder.

diff --git a/src/mantle/database/query/class-post-query-builder.php b/src/mantle/database/query/class-post-query-builder.php
@@ -340,7 +340,9 @@ function ( string $sql, \WP_Query $query ) use ( $die ) {
 	/**
 	 * Dump the SQL query being executed and die.
 	 */
-	public function ddSql(): void {
-		$this->dumpSql( true );
+	public function ddSql(): never {
+		$this->dumpSql( true )->get();
+
+		die( 1 );
 	}
 }
diff --git a/src/mantle/database/query/class-term-query-builder.php b/src/mantle/database/query/class-term-query-builder.php
@@ -173,7 +173,9 @@ function ( mixed $terms, \WP_Term_Query $query ) use ( $die ) {
 	/**
 	 * Dump the SQL query being executed and die.
 	 */
-	public function ddSql(): void {
-		$this->dumpSql( true );
+	public function ddSql(): never {
+		$this->dumpSql( true )->get();
+
+		die( 1 );
 	}
 }