-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPStan: Phase 2 #385
PHPStan: Phase 2 #385
Conversation
*/ | ||
protected $driver; | ||
protected Flysystem $driver; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flysystem looks cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions but looks good.
if ( ! empty( $this->expected_output_substrings ) ) { | ||
$output = $this->tester->getDisplay(); | ||
// todo: add output substring assertions. | ||
// if ( ! empty( $this->expected_output_substrings ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming you left these in on purpose.
@@ -31,7 +31,7 @@ public static function installs_wordpress_set_up_before_class(): void { | |||
* | |||
* @deprecated Logic condensed into {@see \Mantle\Testing\Installation_Manager::after()}. | |||
*/ | |||
$callback = function_exists( 'mantle_after_wordpress_install' ) ? 'mantle_after_wordpress_install' : null; | |||
$callback = function_exists( 'mantle_after_wordpress_install' ) ? 'mantle_after_wordpress_install' : 'null'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supposed to be a string?
Adds PHPStan support to more packages. The remaining packages are the hardest 😮💨 .