Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using SQLite in tests (opt-in) #393

Merged
merged 6 commits into from
May 31, 2023
Merged

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented May 30, 2023

Depends on alleyinteractive/mantle-ci#11

Adds opt-in support for using SQLite in tests in place of MySQL. Uses the db.php drop-in from https://github.com/aaemnnosttv/wp-sqlite-db

@nlemoine
Copy link
Contributor

Hi @srtfisher,

Looks like SQLite is on its way to core. Why not using the official implementation?

Amazing work on Mantle by the way!

Copy link
Contributor

@anubisthejackle anubisthejackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@anubisthejackle
Copy link
Contributor

Why not using the official implementation?

I think the main reason I can see is that the official plugin isn't a simple drop-in db.php which is what we're using for testing purposes.

@srtfisher
Copy link
Member Author

@nlemoine I'd love to! That is actually handled over in our CI script that we use (alleyinteractive/mantle-ci#11) and I can add a TODO to my list to review switching it over. I will second @anubisthejackle here and say that it was mighty simple to get a single db.php added versus a whole set of files from the plugin. Hopefully we can switch over to core's https://wordpress.org/plugins/sqlite-database-integration/ soon enough.

@srtfisher srtfisher merged commit 584d284 into main May 31, 2023
9 checks passed
@srtfisher srtfisher deleted the sqlite-round-3 branch May 31, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants