Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix http-client content_type method #409

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Fix http-client content_type method #409

merged 1 commit into from
Jul 26, 2023

Conversation

nlemoine
Copy link
Contributor

@nlemoine nlemoine commented Jul 23, 2023 •
edited
Loading

Using content_type() multiples times (as with as_form(), since the object is created with default as_json()) results in a header array value which trigger an "array to string conversion" error in Requests

srtfisher
srtfisher approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@srtfisher srtfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@srtfisher srtfisher added the bug Something isn't working label Jul 26, 2023
@srtfisher srtfisher merged commit c352679 into alleyinteractive:main Jul 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srtfisher srtfisher srtfisher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlemoine @srtfisher