Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mail Testing #496

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Add Mail Testing #496

merged 7 commits into from
Feb 21, 2024

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Feb 20, 2024 •
edited

  • Adds $this->assertMailSent()/$this->assertMailNotSent() methods to make it easier to test against the use of wp_mail().
  • Mocks the PHPMailer into the Mantle\Testing\Mail namespace and out of the the wordpress-bootstrap.php file. This change is a breaking change slated for 1.0.

@srtfisher srtfisher mentioned this pull request Feb 20, 2024
Closed
@srtfisher srtfisher enabled auto-merge (squash) February 20, 2024 22:21
attackant
attackant approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@attackant attackant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐙

@srtfisher srtfisher merged commit 4b5aff2 into 1.x Feb 21, 2024
11 checks passed
@srtfisher srtfisher deleted the feature/mock-mail branch February 21, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attackant attackant attackant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srtfisher @attackant