Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch CSS selector #516

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Switch CSS selector #516

merged 2 commits into from
Mar 15, 2024

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Mar 14, 2024 •
edited
Loading

Switch package used to power CSS Selector -> XPath to use Symfony's css-selector package which is more inline with our other dependencies.

mboynes
mboynes approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@mboynes mboynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@srtfisher srtfisher merged commit 0d0343f into 1.x Mar 15, 2024
16 checks passed
@srtfisher srtfisher deleted the feature/css-selector-symfony branch March 15, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboynes mboynes mboynes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srtfisher @mboynes