[1.1] Overhauling the bootloader to be more flexible #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srtfisher
changed the title
attackant
requested changes
Jun 11, 2024
| @@ -28,8 +28,12 @@ class Model_Service_Provider extends Service_Provider { | |||
| * Register the service provider. | |||
| */ | |||
| public function register(): void { | |||
| Model::set_event_dispatcher( $this->app['events'] ); | |||
| } | |||
There was a problem hiding this comment.
Do you mean to leave this method empty now?
| $dirname = basename( dirname( $file->getRealPath() ) ); | ||
| $environment = match ( $dirname ) { | ||
| // Ignore the 'config' directory as an environment. | ||
| 'config', 'configuration' => null, |
There was a problem hiding this comment.
Not really sure, but do any of the changes for loading and merging configuration in this file have performance considerations we should think about?
| * @param class-string<Contracts\Http\Kernel>|null $http HTTP kernel class. | ||
| */ | ||
| public function with_kernels( string $console = null, string $http = null ): static { | ||
| if ( $console && ! in_array( Contracts\Console\Kernel::class, class_implements( $console ), true ) ) { |
There was a problem hiding this comment.
Would a ! class_exists( $handler ) also make sense here? Or would this already be caught? Same question for with_exception_handler method below.
Co-authored-by: Damian <4309872+attackant@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the bootloader to configure an application without any additional arguments. Also, allow the application to be configured through the bootloader. This will allow any application to truly use the framework's features with just:
Previously, this was a goal and worked but not exactly. The queue didn't work well without a kernel and some more configuration. All of this is now behind us and we can call the bootloader in another application and use the queue/database/etc.
With the changes in this PR we can simplify
bootstrap/app.phpto this: