Add initial functionality and tests #1
Conversation
| */ | ||
| private function run() | ||
| { | ||
| if (\is_array($this->path)) { |
There was a problem hiding this comment.
I generally prefer using use statements up top rather than fully qualified paths in the class body. Additionally, the PHP builtins typically don't require a use statement or a fully qualified path (unlike custom functions in WP or other libraries).
There was a problem hiding this comment.
Built-in functions don't require qualification, true, but they can be made infinitesimally faster in some cases when they're fully qualified: PHP-CS-Fixer/PHP-CS-Fixer#3995.
It turns out I was using an old version of PHP-CS-Fixer that added namespaces to all built-in functions. Now that I've upgraded and only some functions are namespaced, I think I'll keep away from use statements for now, since that would make for an inconsistency: some functions would have use statements, some wouldn't.
Summary
As titled.
Notes for reviewers
None.
Changelog entries
Added
Changed
Deprecated
Removed
Fixed
Security