Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve flexibility of context actions #374

Merged
merged 11 commits into from Jan 4, 2016
Merged

Improve flexibility of context actions #374

merged 11 commits into from Jan 4, 2016

Conversation

mboynes
Copy link
Contributor

@mboynes mboynes commented Aug 17, 2015

No description provided.

dlh01
dlh01 reviewed Aug 17, 2015
View reviewed changes
fieldmanager.php
* The dynamic portion of the hook name, $context, refers to the first
* value returned by fm_calculate_context(). For example, the Edit User
* screen would fire "fm_user".
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would note that the new @params are missing docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!

dlh01
dlh01 reviewed Aug 18, 2015
View reviewed changes
fieldmanager.php
* The dynamic portion of the hook name, $context, refers to the first
* value returned by fm_calculate_context(). For example, the Edit User
* screen would fire "fm_user".
* @param string $type The context type, e.g. post, term, submenu.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't type be the post type name, taxonomy name, etc.?

@dlh01
Copy link
Member

dlh01 commented Aug 18, 2015

One question, although I might be misreading the change. Otherwise, 🌳

dlh01
dlh01 reviewed Dec 31, 2015
View reviewed changes
fieldmanager.php
* @return array Contextual information for the current request.
*/
function fm_get_context() {
function fm_get_context( $force = false ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, $force reads as if you're forcing FM to return something when it otherwise wouldn't, which isn't quite what's happening, if I'm following correctly. Maybe FM could do with a dedicated clear or recalculate workflow, or a way to get a new calculated context independently of the static one? (I realize this comment is coming a little late in the 1.0 cycle, though.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feedback. I think in the short term, I'll just rename this to $recalculate.

@dlh01
Copy link
Member

dlh01 commented Dec 31, 2015

Looks 🌳 to me.

mboynes added a commit that referenced this pull request Jan 4, 2016
@mboynes
Merge pull request #374 from alleyinteractive/enhance-context-actions
0a2d0eb 
Improve flexibility of context actions
@mboynes mboynes merged commit 0a2d0eb into master Jan 4, 2016
@mboynes mboynes added this to the 1.0.0 RC milestone Feb 21, 2016
montchr pushed a commit to spiritedmedia/wordpress-fieldmanager that referenced this pull request Apr 20, 2016
Update to FieldManager 1.0.0
4edcc93 
Squashed commit of the following:

commit 9c3de5f
Merge: d739dab 5747ca8
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Fri Mar 4 10:53:42 2016 -0500

    Merge pull request alleyinteractive#469 from alleyinteractive/version-bump

    Bump the version UP

commit 5747ca8
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Fri Mar 4 10:45:56 2016 -0500

    Bump static asset versions

commit d739dab
Merge: 35d6c0f 935989c
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Tue Feb 23 11:42:03 2016 -0500

    Merge pull request alleyinteractive#476 from alleyinteractive/phpdoc-headers

    Update the phpdoc headers for all classes

commit 935989c
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Tue Feb 23 10:22:43 2016 -0500

    Fix typo

commit b9b9c78
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Tue Feb 23 10:21:27 2016 -0500

    Keep reference to this being core's editor

commit d2a601c
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Tue Feb 23 10:17:51 2016 -0500

    Fix inline links

commit 295f53a
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Tue Feb 23 10:07:45 2016 -0500

    Update the phpdoc headers for all classes

commit 35d6c0f
Merge: db3fcb1 9bd9736
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Mon Feb 22 14:29:02 2016 -0500

    Merge pull request alleyinteractive#475 from alleyinteractive/option-label-incr-for

    Update label for attr in incrementable options

commit 9bd9736
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Feb 22 14:18:44 2016 -0500

    Update label for attr in incrementable options

    resolves alleyinteractive#470

commit db3fcb1
Merge: c9ad8f5 c67cf84
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Mon Feb 22 11:02:14 2016 -0500

    Merge pull request alleyinteractive#474 from alleyinteractive/472-datepicker-fields

    alleyinteractive#472 increase to datepicker time field

commit c67cf84
Author: Steven Slack <steven@alleyinteractive.com>
Date:   Sun Feb 21 21:16:47 2016 -0500

    slight increase to datepicker time field

commit c9ad8f5
Merge: 2421871 1627812
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sun Feb 21 20:58:18 2016 -0500

    Merge pull request alleyinteractive#473 from alleyinteractive/471-vertical-tab-border

    471 vertical tab border and box shadow

commit 1627812
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sun Feb 21 20:57:55 2016 -0500

    Fix indentation

commit 5a299e5
Author: Steven Slack <steven@alleyinteractive.com>
Date:   Sun Feb 21 20:50:33 2016 -0500

    remove insertion on line 1

commit afc7e39
Author: Steven Slack <steven@alleyinteractive.com>
Date:   Sun Feb 21 20:48:31 2016 -0500

    fixes issue alleyinteractive#471 vertical tabs with border and box shadow

commit cb8cd7e
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 19:23:19 2016 -0500

    Bump the version UP

commit 2421871
Merge: 6c46203 72b63ed
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 19:07:08 2016 -0500

    Merge pull request alleyinteractive#466 from alleyinteractive/397-macros

    Target :input, not .input, in label macros

commit 6c46203
Merge: 9614022 2065fce
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 19:06:10 2016 -0500

    Merge pull request alleyinteractive#467 from alleyinteractive/post-parent-bugs

    Address several bugs with save_to_post_parent

commit 2065fce
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 16:44:49 2016 -0500

    Absorb unit test updates from alleyinteractive#307

commit e6df3f7
Merge: 9ddc2eb 458f7e1
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 16:35:25 2016 -0500

    Merge branch 'master' into post-parent-bugs

commit 9ddc2eb
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 16:35:19 2016 -0500

    Prevent repeatable save_to_post_parent fields

commit 6478c69
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 16:35:01 2016 -0500

    Test field rendering and normalize field values

    Closes alleyinteractive#284

commit 9614022
Merge: 7ede93a f69fb5e
Author: Matt Johnson <matt@alleyinteractive.com>
Date:   Sat Feb 20 16:08:51 2016 -0500

    Merge pull request alleyinteractive#464 from alleyinteractive/51_repeatable_grid

    JS refactor to support grid serialization on multiple grid adds

commit f69fb5e
Merge: cd8c4a4 c7df25c
Author: Matt Johnson <matt@alleyinteractive.com>
Date:   Sat Feb 20 16:05:42 2016 -0500

    Merge branch '51_repeatable_grid' of github.com:alleyinteractive/wordpress-fieldmanager into 51_repeatable_grid

commit cd8c4a4
Author: Matt Johnson <matt@alleyinteractive.com>
Date:   Sat Feb 20 16:05:30 2016 -0500

    PR fixes

commit 72b63ed
Author: David Herrera <david@alleyinteractive.com>
Date:   Sat Feb 20 15:51:41 2016 -0500

    Target :input, not .input, in label macros

    From the docs: "Selects all input, textarea, select and button elements"

commit 7ede93a
Merge: 871a428 aea73e5
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 15:49:03 2016 -0500

    Merge pull request alleyinteractive#459 from alleyinteractive/displayif-updates

    Address some buggy display-if cases

commit 871a428
Merge: 458f7e1 b3f54ba
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 15:48:42 2016 -0500

    Merge pull request alleyinteractive#457 from alleyinteractive/333-dynamic-element-label

    When an element is dynamically added, update its label's `for` too

commit c7df25c
Merge: 40e1d33 458f7e1
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 15:34:15 2016 -0500

    Merge branch 'master' into 51_repeatable_grid

commit 40e1d33
Author: Matt Johnson <matt@alleyinteractive.com>
Date:   Sat Feb 20 15:21:44 2016 -0500

    JS refactor to support grid serialization on multiple grid adds

commit 458f7e1
Merge: befb3c2 86f4f7f
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 15:16:07 2016 -0500

    Merge pull request alleyinteractive#442 from alleyinteractive/bugfix-empty-repeatable-multiselect

    fix handling for repeatable multiple select fields alleyinteractive#352

commit befb3c2
Merge: fe9d5a0 5ac8030
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 15:15:21 2016 -0500

    Merge pull request alleyinteractive#458 from alleyinteractive/337-qtags-buttons-dynamic

    Initialize QuickTags buttons on dynamic RichTextFields

commit fe9d5a0
Merge: b2fed2a a8d1549
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 15:07:55 2016 -0500

    Merge pull request alleyinteractive#461 from aaronjorbin/update-qunit

    update Qunit to 1.21.0

commit b2fed2a
Merge: 6b51fa1 06c0cf6
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 15:06:17 2016 -0500

    Merge pull request alleyinteractive#462 from aaronjorbin/php7-is-now

    remove php7 from allowed failures

commit 06c0cf6
Author: Aaron Jorbin <aaron@jorb.in>
Date:   Sat Feb 20 19:59:00 2016 +0000

    remove php7 from allowed failures

commit a8d1549
Author: Aaron Jorbin <aaron@jorb.in>
Date:   Sat Feb 20 19:54:03 2016 +0000

    update qunit to 1.21.0

commit aea73e5
Author: David Herrera <david@alleyinteractive.com>
Date:   Sat Feb 20 14:44:54 2016 -0500

    Describe new display-if tests

commit b0a07ea
Author: David Herrera <david@alleyinteractive.com>
Date:   Sat Feb 20 14:44:30 2016 -0500

    Tweak measuring visibility in numeric display-if tests

commit b9be6d7
Author: David Herrera <david@alleyinteractive.com>
Date:   Sat Feb 20 14:26:29 2016 -0500

    Address some buggy display-if cases

    - Allow numeric values to be used as the display-if 'value'
    - Allow checkboxes to be used as display-if triggers
    - Allow autocompletes to be used as display-if triggers
    - Improve some cases of handling field visibility on load

commit 5ac8030
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 10:35:33 2016 -0800

    Initialize QuickTags buttons on dynamic RichTextFields

    Core doesn't do this for us by default.

commit 5f9722e
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 13:10:42 2016 -0500

    don't allow repeatable save_to_post_parent fields

commit a53c3ec
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 13:09:42 2016 -0500

    Skip save if only_save_to_post_parent

commit b3f54ba
Merge: 25a0f36 6b51fa1
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 09:49:14 2016 -0800

    Merge branch 'master' into 333-dynamic-element-label

commit 6b51fa1
Merge: ba310d4 75c2d04
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 12:48:53 2016 -0500

    Merge pull request alleyinteractive#455 from alleyinteractive/392-new-tab-click-events

    Properly bind tab button click events for new tabbed groups

commit 25a0f36
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 09:47:05 2016 -0800

    When an element is dynamically added, update its label's `for` too

commit 75c2d04
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 12:39:03 2016 -0500

    Coding standards

commit e33dbc6
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 09:26:37 2016 -0800

    Only generate the original counter once

    Prevents counter from being set to a group that already exists when a
    group is removed.

commit 9899798
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 09:19:01 2016 -0800

    Fix coding standards

commit 86f4f7f
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 09:08:51 2016 -0800

    Fix copy pasta in documentation

commit ba310d4
Merge: 915af49 baed89f
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 12:03:09 2016 -0500

    Merge pull request alleyinteractive#454 from alleyinteractive/lint-all-builds

    Run `php -l` on all builds to catch syntax errors

commit bfea2e0
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 09:00:56 2016 -0800

    Properly bind tab button click events for new tabbed groups

    Previously, the click events would only be bound on $(document).ready(),
    leaving dynamically added groups without bound events.

commit 496c2ca
Merge: 223fd1d 915af49
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 08:41:38 2016 -0800

    Merge branch 'master' into bugfix-empty-repeatable-multiselect

commit baed89f
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 08:40:48 2016 -0800

    Run `php -l` on all builds to catch syntax errors

commit 915af49
Merge: 1a58b3f 0d8f2eb
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 11:37:41 2016 -0500

    Merge pull request alleyinteractive#453 from alleyinteractive/retool-travis-builds

    Retool Travis to provide same level of coverage with less builds

commit 0d8f2eb
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 08:24:20 2016 -0800

    Ensure `multisite.xml` is present to run multisite tests

commit 80200bf
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 08:22:24 2016 -0800

    Also run WP 4.3 on PHP 5.3

commit 1a58b3f
Merge: a7d0348 03898ea
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 11:21:29 2016 -0500

    Merge pull request alleyinteractive#370 from alleyinteractive/presave_tweaks

    Update prepare_data() to better use the passed field

commit 8543fbe
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 08:20:59 2016 -0800

    Retool Travis to provide same level of coverage with less builds

commit 03898ea
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 08:02:45 2016 -0800

    Revert change that we don't know if it won't have unexpected consequences

commit a7d0348
Merge: 957ff3a 4a30095
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Sat Feb 20 10:53:24 2016 -0500

    Merge pull request alleyinteractive#451 from alleyinteractive/347-skip-save-submenu

    Submenu context should respect `skip_save` on its fields

commit 957ff3a
Merge: a6d8d99 5bd8822
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Sat Feb 20 09:30:26 2016 -0500

    Merge pull request alleyinteractive#261 from alleyinteractive/pass-values-to-markup-filters

    pass field $values to fm_element_markup_start and fm_element_markup_end ...

commit a6d8d99
Merge: 8c28773 207ac57
Author: Matt Johnson <matt@alleyinteractive.com>
Date:   Fri Feb 19 22:59:09 2016 -0500

    Merge pull request alleyinteractive#452 from alleyinteractive/361_only_save_to_taxo

    361 only save to taxo

commit 207ac57
Author: xmattus <matt@alleyinteractive.com>
Date:   Sat Feb 20 03:47:49 2016 +0000

    fix autocomplete fields and fix a bunch of tests to expect blank strings instead of empty arrays

commit 4ee4d49
Merge: be82821 8c28773
Author: Matt Johnson <matt@alleyinteractive.com>
Date:   Fri Feb 19 22:20:23 2016 -0500

    Merge branch 'master' of github.com:alleyinteractive/wordpress-fieldmanager into 361_only_save_to_taxo

commit be82821
Author: Matt Johnson <matt@alleyinteractive.com>
Date:   Fri Feb 19 22:20:21 2016 -0500

    prevent saving to postmeta when only_save_to_taxonomy is true

commit fd9a645
Merge: c5caf09 8c28773
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Fri Feb 19 22:19:36 2016 -0500

    Merge branch 'master' into presave_tweaks

commit 8c28773
Merge: 5c55d5e a4df7f5
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 22:14:13 2016 -0500

    Merge pull request alleyinteractive#440 from alleyinteractive/user-taxonomies

    Allow saving taxonomy data to users

commit 4a30095
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 19:01:38 2016 -0800

    Fix error notice by fully registering the view

commit a4df7f5
Merge: bdab69b ef51a1f
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Fri Feb 19 21:49:44 2016 -0500

    Merge branch 'master' into user-taxonomies

    # Conflicts:
    #	tests/php/test-fieldmanager-datasource-term.php

commit b05378c
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 18:31:59 2016 -0800

    Ensure submenu context respects `skip_save` on its primary field

commit 9461829
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 18:27:44 2016 -0800

    Failing testcase for submenu context respecting `skip_save`

commit 5c55d5e
Merge: 74c2434 69dec43
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 21:24:46 2016 -0500

    Merge pull request alleyinteractive#449 from alleyinteractive/287-option-sanitize-callback

    Define custom `sanitize` callback early, to allow override by `$options`

commit 74c2434
Merge: ef51a1f 39d9ce9
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 21:24:34 2016 -0500

    Merge pull request alleyinteractive#450 from alleyinteractive/editorconfig

    Add `.editorconfig` for consistent formatting standards between editors

commit bdab69b
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Fri Feb 19 21:19:41 2016 -0500

    test saving term relationships to users

commit 39d9ce9
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 18:13:09 2016 -0800

    Add `.editorconfig` for consistent formatting standards between editors

commit 69dec43
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 17:59:11 2016 -0800

    Define custom `sanitize` callback early, to allow override by `$options`

commit 5bd8822
Merge: 5193bab 089d1d3
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Fri Feb 19 20:24:06 2016 -0500

    Merge branch 'master' into pass-values-to-markup-filters

    # Conflicts:
    #	php/class-fieldmanager-field.php

commit ef51a1f
Merge: 8f9554e 769ef9f
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 20:22:36 2016 -0500

    Merge pull request alleyinteractive#443 from alleyinteractive/102-description-top

    Use `$field->description_after_element` to control description position

commit 8f9554e
Merge: 55c0bfe 8c962a5
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 20:02:48 2016 -0500

    Merge pull request alleyinteractive#446 from alleyinteractive/360_skip_save

    honor $skip_save for child elements inside groups

commit 55c0bfe
Merge: ba4c2d1 cea1865
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 20:02:17 2016 -0500

    Merge pull request alleyinteractive#448 from alleyinteractive/coding-standards-again

    First pass at hooking up PHPCS for coding standards sniffs

commit cea1865
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 16:26:22 2016 -0800

    First pass at hooking up PHPCS for coding standards sniffs

commit ba4c2d1
Merge: 089d1d3 a32e9ba
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 19:04:07 2016 -0500

    Merge pull request alleyinteractive#445 from alleyinteractive/rta-fouc

    Remove RTA border to soften FOUC

commit 8c962a5
Author: xmattus <matt@alleyinteractive.com>
Date:   Fri Feb 19 23:26:32 2016 +0000

    honor $skip_save for child elements inside groups

commit 223fd1d
Author: Noah Schoenholtz <noah@alleyinteractive.com>
Date:   Fri Feb 19 18:03:43 2016 -0500

    add handling for the missing options subclass (radios) and make unit tests work in 4.3

commit 089d1d3
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 14:45:13 2016 -0800

    Link to the build status

commit a32e9ba
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Fri Feb 19 17:40:04 2016 -0500

    Remove RTA border to soften FOUC

commit 8d061d3
Merge: 716d6e1 b8734d1
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 17:26:42 2016 -0500

    Merge pull request alleyinteractive#439 from alleyinteractive/356-fix-term-datasource-repeatable

    Pass `$append = true` after first save when datasource repeats

commit 716d6e1
Merge: ba4f6b5 d758e32
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 17:19:48 2016 -0500

    Merge pull request alleyinteractive#444 from alleyinteractive/132_zero

    accommodate fields with literal string value "0" and add test

commit d758e32
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 14:05:08 2016 -0800

    Tests don't lie

commit f251e42
Author: Matt Johnson <matt@alleyinteractive.com>
Date:   Fri Feb 19 16:48:48 2016 -0500

    accommodate fields with literal string value "0" and add test

commit 769ef9f
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 12:45:05 2016 -0800

    Use `$field->description_after_element` to control description position

    Defaults to `true`. `false` places it before the element.

commit b8734d1
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 12:00:01 2016 -0800

    Respect `append_taxonomy` attribute

    If `append_taxonomy` is ever true, then it's always true.

commit 395736d
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 11:50:23 2016 -0800

    Get the context from the oldest parent, where it's assigned

commit 795bdca
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 11:29:45 2016 -0800

    Remove unnecessary method definition

commit cea0ffb
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 11:25:55 2016 -0800

    Introduce saving taxonomy relationships as a concern of Storable_Context

    It makes more sense to collect all of the terms needing a relationship
    to the context, and then save the relationships at once

commit 54f9d08
Author: Noah Schoenholtz <noah@alleyinteractive.com>
Date:   Fri Feb 19 14:00:29 2016 -0500

    fix handling for repeatable multiple select fields alleyinteractive#352

commit 26e4052
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Fri Feb 19 12:28:09 2016 -0500

    Allow saving taxonomy data to users

    Really.

commit 6b66290
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 09:26:38 2016 -0800

    Revert "Pass `$append = true` after first save when datasource repeats"

    This reverts commit e2bc5cd.

commit 8702f46
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 08:34:49 2016 -0800

    Add a testcase for disabling the append after first save behavior

commit e2bc5cd
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 08:32:42 2016 -0800

    Pass `$append = true` after first save when datasource repeats

    When a Term datasource is a part of a repeatable group, the expected
    behavior is to save all terms present in all groups, not just the term
    of the last group. By passing `$append = true` after the first save, we
    can ensure subsequent terms maintain their relationship to the post.

commit ff09745
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Fri Feb 19 08:26:51 2016 -0800

    Failing testcase for saving terms of repeating groups

commit ba4f6b5
Merge: c95e399 357427f
Author: Daniel Bachhuber <daniel@handbuilt.co>
Date:   Thu Jan 21 12:00:42 2016 -0800

    Merge pull request alleyinteractive#434 from goldenapples/433-term.php-context

    Recognize term.php as context for "term"

commit 357427f
Author: Nathaniel Taintor <goldenapplesdesign@gmail.com>
Date:   Thu Jan 21 14:34:49 2016 -0500

    Add code comment with link to core changeset

    Preserve a little bit of history in the codebase, in case there are
    questions later (or the core changeset is reverted).

commit 0cb0468
Author: Nathaniel Taintor <goldenapplesdesign@gmail.com>
Date:   Thu Jan 21 13:37:57 2016 -0500

    spaces to tabs

commit 65ca2fd
Author: Nathaniel Taintor <goldenapplesdesign@gmail.com>
Date:   Thu Jan 21 13:34:52 2016 -0500

    Recognize term.php as context for "term"

    Since https://core.trac.wordpress.org/changeset/36308, the link for
    editing a term is `term.php`, not `edit-tags.php?action=edit`. This
    looks for that screen context in calculating Fieldmanager context
    values.

commit c95e399
Merge: f7897be c80786c
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Wed Jan 13 17:28:30 2016 -0500

    Merge pull request alleyinteractive#430 from alleyinteractive/help-travis

    Hopefully cut travis' workload in half

commit c80786c
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Jan 7 10:24:28 2016 -0500

    Hopefully cut travis' workload in half

commit f7897be
Merge: 23662c0 0d00aec
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Wed Jan 6 09:42:17 2016 -0500

    Merge pull request alleyinteractive#428 from alleyinteractive/enrico-sorcinelli-datasource-user

    Add wildcards to get_users search

commit 23662c0
Merge: d7ba7b5 abcf026
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Wed Jan 6 09:32:27 2016 -0500

    Merge pull request alleyinteractive#213 from alleyinteractive/set-properties

    Update how properties are set

commit 0d00aec
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Wed Jan 6 09:26:57 2016 -0500

    Test user datasource searching

commit 8ab1e00
Author: Enrico Sorcinelli <enrico.sorcinelli@italiaonline.it>
Date:   Tue Jan 5 23:09:53 2016 +0100

    Added wildcards to get_users search

commit c5caf09
Merge: 429a140 d7ba7b5
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 12:55:17 2016 -0500

    Merge branch 'master' into presave_tweaks

commit abcf026
Merge: dc2f1ba d7ba7b5
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 12:54:32 2016 -0500

    Merge branch 'master' into set-properties

commit d7ba7b5
Merge: eab5610 7ae57e8
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 12:04:55 2016 -0500

    Merge pull request alleyinteractive#222 from alleyinteractive/submenu-success

    Allow the submenu success message to be configurable

commit eab5610
Merge: d3b94e6 8dd191b
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 12:04:30 2016 -0500

    Merge pull request alleyinteractive#343 from alleyinteractive/quickedit-title

    Implement titles in quicktext

commit d3b94e6
Merge: 0a2d0eb 8dd895e
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 11:02:41 2016 -0500

    Merge pull request alleyinteractive#373 from alleyinteractive/meta_boxes_to_remove_action

    Change the action where meta boxes are removed

commit 0a2d0eb
Merge: bad3343 8ad9f49
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 11:01:49 2016 -0500

    Merge pull request alleyinteractive#374 from alleyinteractive/enhance-context-actions

    Improve flexibility of context actions

commit bad3343
Merge: 7577ead 553cba7
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 11:00:54 2016 -0500

    Merge pull request alleyinteractive#344 from alleyinteractive/datepicker-template

    Remove closing slash from a.m./p.m. select element

commit 7ae57e8
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 10:48:24 2016 -0500

    Add unit test and clean up for merge

commit cdfbcda
Merge: 3b3b4e5 7577ead
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 10:31:00 2016 -0500

    Merge branch 'master' into submenu-success

commit 8dd191b
Merge: 52fab12 7577ead
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 10:29:00 2016 -0500

    Merge branch 'master' into quickedit-title

commit 553cba7
Merge: 339eb86 7577ead
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 10:27:40 2016 -0500

    Merge branch 'master' into datepicker-template

    # Conflicts:
    #	templates/datepicker.php

commit 8ad9f49
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 10:24:38 2016 -0500

    Fix calculate context unit tests

commit 8dd895e
Merge: 518977a 7577ead
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 10:17:53 2016 -0500

    Merge branch 'master' into meta_boxes_to_remove_action

commit 7577ead
Merge: 446a096 ab2b8fc
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 10:15:25 2016 -0500

    Merge pull request alleyinteractive#424 from alleyinteractive/fields-ui-modifications

    fields ui modifications

commit 446a096
Merge: 4d3a684 e4199e0
Author: Matthew Boynes <mboynes@alleyinteractive.com>
Date:   Mon Jan 4 10:14:57 2016 -0500

    Merge pull request alleyinteractive#412 from alleyinteractive/colorpicker

    Add a colorpicker field

commit ab2b8fc
Author: Steven Slack <steven@alleyinteractive.com>
Date:   Thu Dec 31 16:53:21 2015 -0500

    css rules to new line

commit e0afb3f
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 16:45:23 2015 -0500

    Change variable name to be more clear

commit 59bb4cb
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 16:44:06 2015 -0500

    Hopefully fix tests in 4.3

commit 0c7dcc5
Merge: 99b02c9 73e422e
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 16:25:51 2015 -0500

    Merge branch 'master' into fields-ui-modifications

commit e4199e0
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 16:23:51 2015 -0500

    Improve phpdoc for Fieldmanager_Colorpicker::sanitize_hex_color

commit 18a0caf
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 16:17:35 2015 -0500

    Coding standards

commit 99b02c9
Author: Steven Slack <steven@alleyinteractive.com>
Date:   Thu Dec 31 16:11:31 2015 -0500

    spaces to tabs part 2

commit 8f4b698
Author: Steven Slack <steven@alleyinteractive.com>
Date:   Thu Dec 31 16:09:21 2015 -0500

    spaces to tabs

commit cbcf00a
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 16:01:00 2015 -0500

    phpdoc

commit d7a822a
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 15:59:02 2015 -0500

    Test context actions

commit e4dc652
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 15:35:33 2015 -0500

    Test new context actions

commit b51f4f9
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 15:35:21 2015 -0500

    Allow reloading of fm_get_context()

commit 6f6a633
Merge: df47d42 a739339
Author: Steven Slack <steven@alleyinteractive.com>
Date:   Thu Dec 31 15:08:32 2015 -0500

    Merge branch 'group-ui-updates' of github.com:alleyinteractive/wordpress-fieldmanager into fields-ui-modifications

commit 070c5c2
Merge: d44e245 39ca865
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 15:08:15 2015 -0500

    Merge branch 'master' into enhance-context-actions

commit df47d42
Author: Steven Slack <steven@alleyinteractive.com>
Date:   Thu Dec 31 15:07:23 2015 -0500

    toggle indicator added to collapsible field groups

commit 1e7abc8
Merge: 03b7beb 6f64e74
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Dec 31 14:46:20 2015 -0500

    Merge branch 'master' into colorpicker

commit 6601ad7
Author: Steven Slack <steven@alleyinteractive.com>
Date:   Thu Dec 31 13:13:40 2015 -0500

    fixed top border for horizontal tab groups

commit 5c391e9
Author: Steven Slack <steven@alleyinteractive.com>
Date:   Thu Dec 31 13:05:10 2015 -0500

    Draggable and Collapsable field handlers hover effect

commit 03b7beb
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Fri Dec 11 22:41:20 2015 -0500

    Add unit tests and fix what the unit tests caught

commit 775b2a6
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Fri Dec 11 22:23:34 2015 -0500

    Correct phpdoc

commit decd356
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Fri Dec 11 22:21:01 2015 -0500

    Add a colorpicker field

commit 518977a
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Aug 20 09:22:18 2015 -0400

    Delay the action to give more meta boxes a chance to register

commit d44e245
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Aug 20 09:21:05 2015 -0400

    Correct misinformation in docs

commit 56f7a1d
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Aug 17 21:40:41 2015 -0400

    Improve docs, fix bug where an action always fired

commit 6f8980d
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Aug 17 17:49:05 2015 -0400

    Improve flexibility of context actions

commit 438f20c
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Mon Aug 17 17:40:58 2015 -0400

    Change the action where meta boxes are removed

commit 429a140
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Wed Jul 29 09:14:21 2015 -0400

    Update prepare_data() to better use the passed field

commit 339eb86
Author: David Herrera <david@alleyinteractive.com>
Date:   Wed Jun 17 13:37:11 2015 -0400

    Remove closing slash from a.m./p.m. select element

commit 52fab12
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Jun 11 17:45:14 2015 -0400

    Implement titles in quicktext

    closes alleyinteractive#340

commit 5193bab
Author: Josh Kadis <josh@alleyinteractive.com>
Date:   Wed Dec 3 13:02:36 2014 -0800

    pass field $values to fm_element_markup_start and fm_element_markup_end filters

commit 3b3b4e5
Author: Daniel Bachhuber <d@danielbachhuber.com>
Date:   Thu Oct 2 14:56:35 2014 -0700

    Allow the submenu success message to be configurable

commit dc2f1ba
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Thu Sep 11 12:40:12 2014 -0400

    Throw an exception for invalid properties if debug mode is enabled

commit 30e66a2
Author: Matt Boynes <mboynes@alleyinteractive.com>
Date:   Wed Sep 10 21:46:37 2014 -0400

    Update how properties are set
@renatonascalves renatonascalves deleted the enhance-context-actions branch February 21, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0 RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mboynes @dlh01