Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Update recursive site theme loop so non-string values are skipped #309

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Update recursive site theme loop so non-string values are skipped #309

merged 1 commit into from
Dec 24, 2020

Conversation

jameswburke
Copy link
Contributor

@jameswburke jameswburke commented Dec 24, 2020 •
edited
Loading

Summary

As titled.

Notes for reviewers

None.

Changelog entries

  • Fixed: A bug where the site theme recursion was hitting a type mismatch.

Ticket(s)

None.

@jameswburke jameswburke requested a review from a team December 24, 2020 21:14
amyevans
amyevans approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@amyevans amyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@jameswburke jameswburke merged commit 6047e64 into main Dec 24, 2020
@jameswburke jameswburke deleted the fix/site-theme-check-string branch December 24, 2020 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyevans amyevans amyevans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jameswburke @amyevans