Skip to content
This repository has been archived by the owner on Jun 6, 2018. It is now read-only.

Commit

Permalink
log TS3 errors on user creation
Browse files Browse the repository at this point in the history
returns no username on failure to prevent storing empty perm key in authservicesinfo models
  • Loading branch information
Adarnof committed May 9, 2016
1 parent 20fdcc5 commit 8a691fc
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions services/managers/teamspeak3_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,11 @@ def add_user(username, corp_ticker):
if 'keys' in ret:
if 'token' in ret['keys']:
token = ret['keys']['token']
logger.info("Created permission token for user %s on TS3 server" % username_clean)
return username_clean, token
except:
pass
logger.info("Created permission token for user %s on TS3 server" % username_clean)

return username_clean, token
logger.exception("Failed to add teamspeak user %s - received response: %s" % (username, ret))
return "",""

@staticmethod
def add_blue_user(username, corp_ticker):
Expand All @@ -212,12 +212,14 @@ def add_blue_user(username, corp_ticker):
if 'keys' in ret:
if 'token' in ret['keys']:
token = ret['keys']['token']

logger.info("Created permission token for blue user %s on TS3 server" % username_clean)
return username_clean, token
except:
pass
logger.info("Created permission token for blue user %s on TS3 server" % username_clean)
logger.exception("Failed to add blue teamspeak user %s - received response: %s" % (username, ret))
return "",""


return username_clean, token


@staticmethod
def delete_user(uid):
Expand Down

0 comments on commit 8a691fc

Please sign in to comment.