New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dota & CS2 support #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds IProtobufBinding & INetworkSerializable interfaces and CNetworkSerializerPB class
This prevents static initialization problem that was arising where CUtlVector constructor was called after commands were added to it, resulting in an empty list when it gets to the registration step
Thanks to komashchenko
Co-authored-by: GAMMACASE <31375974+GAMMACASE@users.noreply.github.com>
Per our discussion on Discord, we will be merging this as-is for now so that MM:S builds can start going. A separate issue will be created for progress tracking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a WIP and all the stuff could be changed until marked as ready.
PR Completion status:
If you have anything to add, please make sure to pr them to my initial branch as well as discuss them beforehand in the AlliedModders discord in appropriate channels.
This is a collaborative work and a lot of the research and reversing was done by: SlidyBat#4737, Poggu#5993, psychonic#9045, zer0.k#2613, Mooshua#1857, Boeing 666#1307, komashchenko, and others from the AM Discord. So huge thanks to them!