New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix @spec not targeting clients in CSGO or CSS unassigned team. #1034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't really comment on whether or not this change is something we'll take, but this logic can be cleaned up.
I'm definitely not a fan of taking this without more justification (if just for the sake of the process), unassigned is not spec (but I can see why it makes sense), but if this is done it should be for all games not gated on CS. |
I don't know the other game can exit "Choose team". But I can exit in CSS or CSGO. Some players in spectator but they exclude @SPEC. |
Spec has different semantics in cstrike, for instance when I played music automatically unassigned was immune. I didn't use this targeting but it was still treated differently. This is the same as the 'White' team in TF (which was legit, TF has 4 active teams) but I think now fired folk papered over years ago. Anyway, DoD:S is the only outlier I think on this for population, HL2:DM can likely weather the changes. |
Optimized
@asherkin how do you feel about this one? Lets merge or give closure to the issue if we can. |
@TianQiBuTian these are actually very different scenarios. I don't think we can transparently handle this situation based on this change (although I agree it may indeed be a gap, and we should have a different target covering this). Thank you very much for trying to improve SM, but at this time I don't think we want this upstream. PS: While not relevant to AM, this may provide some humour from a simpler time: http://plaguefest.com/threads/abuse-by-afk-man.14335/ |
In CSGO or CSS exit Choose team. It won't be teamid 1, it's 0.