Add WritePackFunction and ReadPackFunction natives #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds type safety to CDataPack. Cells can't be read as Float anymore. Now you're able to store a function pointer in a datapack and be sure the pointer can't be read as a cell and a cell can't be read as a function pointer.
|
Looks good. |
dvander
added a commit
that referenced
this pull request
Aug 12, 2014
Add WritePackFunction and ReadPackFunction natives
A quick note to say that this breaks plugins that used SetPackPosition to pull data from an arbitrary point in a stream. If that wasn't the intended use of the function then it's not important, but it has been used that way in a few cases. |
|
SetPackPosition should only ever be used with the return value of a previous GetPackPosition, the packing format has always been an implementation detail. The docs could probably call this out better. |
|
Good point about GetPackPosition, it makes way more sense to store that value and use it again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type safety to CDataPack. Cells can't be read as Float anymore. Now
you're able to store a function pointer in a datapack and be sure the
pointer can't be read as a cell and a cell can't be read as a function
pointer.
1 more byte is used in the datapack data stream per entry to store the type now.