Fixed memory leak #1251
Merged
Fixed memory leak #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a pack was cleared or destroyed the String and Raw types could cause memory leaks. This happens when "position" is sitting at the end of the vector and can never get past the "if (pos >= elements.length())" statement. This means there is a memory leak in any plugin that clears/destroys a pack with strings and doesn't set the position to length-1 or less beforehand.
KyleSanderson
requested changes
Apr 27, 2020
KyleSanderson
approved these changes
Apr 27, 2020
|
@hlstriker can I get a r? on that additional delete operator for the array? I think after that we should be good here. |
|
This fix looks very brittle. Really, the RemoveItem loop should not even be necessary. I would either: (1) Remove the CDataPack cache, since it almost certainly useless, or |
|
@KyleSanderson nice catch, seems good. @dvander, I agree it's not the end all fix. I'd like to implement your suggestions but it's a bit beyond myself and my available time right now. |
fengjixuchui
added a commit
to fengjixuchui/sourcemod
that referenced
this pull request
Apr 28, 2020
datapack: free all elements on clear (alliedmodders#1251)
snorux
pushed a commit
to snorux/GFLZE-SourceMod
that referenced
this pull request
Apr 28, 2020
asherkin
pushed a commit
that referenced
this pull request
Apr 30, 2020
When a pack was cleared or destroyed the String and Raw types could cause memory leaks. This happens when "position" is sitting at the end of the vector and can never get past the "if (pos >= elements.length())" statement. This means there is a memory leak in any plugin that clears/destroys a pack with strings and doesn't set the position to length-1 or less beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pack was cleared or destroyed the String and Raw types could cause memory leaks. This happens when "position" is sitting at the end of the vector and can never get past the "if (pos >= elements.length())" statement. This means there is a memory leak in any plugin that clears/destroys a pack with strings and doesn't set the position to length-1 or less beforehand.