Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Command Group" override type admin flags #1349

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Fix "Command Group" override type admin flags #1349

merged 1 commit into from
Sep 7, 2020

Conversation

Sikarii
Copy link
Contributor

@Sikarii Sikarii commented Sep 4, 2020

Fixes "Command Group" override type getting set wrong flags upon the creation of the command group override.

One way to test this broken behaviour is to:

  1. Create an admin command with ADMFLAG_ROOT admin flags initially and assign it under a command group MyTestGroup.
    • RegAdminCmd("sm_testcommand", Command_Test, ADMFLAG_ROOT, "Description", "MyTestGroup");
  2. Create a command group override within admin_overrides.cfg - "@MyTestGroup" "".
  3. Make sure you do not have ROOT permissions, boot up the server and observe that you cannot access "sm_testcommand".

Copy link
Member

@asherkin asherkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - I love how this one survived the ages.

It must be almost 10 years since I also tried to setup command group overrides and just went "well that doesn't work" - so great job digging into it and fixing them!

@asherkin asherkin merged commit f12b3a2 into alliedmodders:master Sep 7, 2020
@Sikarii Sikarii deleted the fix-cmd-group-update-flags branch September 7, 2020 13:03
@ambaca
Copy link
Contributor

ambaca commented Sep 9, 2020

I have tried to test "Command group" one whole day for nothing :D dam bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants