Optional autoload extensions

[Kxnrl]

sometimes, we don't need auto load that extension.

[peace-maker]

What is your use case where those extensions cause you trouble? Some extensions provide passive game fixes like fixing precaching issues in OnMapStart in CS:GO, so not loading them could do more harm than good.

[asherkin]

Some extensions provide passive game fixes like fixing precaching issues in OnMapStart in CS:GO, so not loading them could do more harm than good.

The game support extensions are actually autoloaded by core explicitly:

sourcemod/core/sourcemod.cpp

Lines 477 to 484 in c3e6428

	/* Load any game extension */
	const char *game_ext;
	if ((game_ext = g_pGameConf->GetKeyValue("GameExtension")) != NULL)
	{
	char path[PLATFORM_MAX_PATH];
	ke::SafeSprintf(path, sizeof(path), "%s.ext." PLATFORM_LIB_EXT, game_ext);
	extsys->LoadAutoExtension(path);
	}

[Kxnrl]

What is your use case where those extensions cause you trouble? Some extensions provide passive game fixes like fixing precaching issues in OnMapStart in CS:GO, so not loading them could do more harm than good.

Just make them as optinal.
I reach extension load limit.
I don't know why I can not load more then 40 extensions (windows 2016/2019).
for multi mod server, the extension list is changeable.
examples:
https://github.com/Kxnrl/Store/blob/master/store.sp#L35
https://github.com/Kxnrl/MiniGames/blob/master/MiniGames.sp#L47

[peace-maker]

Not being able to load more than X extensions seems to be a bug, could you file a bug with as much info about that as you can please?

Adding the AUTOLOAD_EXTENSIONS guard for clientprefs seems fine, eventhough the clientprefs plugin strongly depends on the extension, so if you have that plugin loaded the extension will be loaded anyways. Since the game extensions are autoloaded automatically as asherkin pointed out, adding the guard to the cstrike and tf2 includes does nothing. Could you switch this up to only change the clientprefs include file, please?

[Kxnrl]

Not being able to load more than X extensions seems to be a bug, could you file a bug with as much info about that as you can please?

Adding the AUTOLOAD_EXTENSIONS guard for clientprefs seems fine, eventhough the clientprefs plugin strongly depends on the extension, so if you have that plugin loaded the extension will be loaded anyways. Since the game extensions are autoloaded automatically as asherkin pointed out, adding the guard to the cstrike and tf2 includes does nothing. Could you switch this up to only change the clientprefs include file, please?

The problem has nothing to do with the extension itself, but the 40th cannot be loaded.
Edit: OS (win2016/win2019)