Don't recalculate Steam ID every frame when waiting for validated auth.

[psychonic]

Right now, RunAuthChecks runs every frame and calls UpdateAuthId for each player that isn't validated yet. This PR skips the Steam ID calculation part of UpdateAuthId if the auth id hasn't changed since the last run.

[psychonic]

I made another change unrelated to this issue, but related to auth. It seems fitting here rather than to touch some of the same code in another new branch.

This was pointed out by @KyleSanderson:
GetClientAuthString has long (forever?) worked before a client was authorized if the validate param is set to false (or before it existed). This also became true for the newer GetClientAuthId. As soon as the first auth queue check was done, one frame after ClientConnect, the data was available. GetPlayerAccountId, however, previously worked immediately in OnClientConnect if validate was false. This broke when refactoring auth logic.

This latest commit makes all of these work as early as in OnClientConnect (again, if the call doesn't require the auth id to be validated).

[KyleSanderson]

I question the placement of this with 410 below it.

[KyleSanderson]

Overall this looks good, the behaviour change will eliminate the need for people hooking player_connect and other grotesque non-portable things.

Maybe the authid should be compared instead of the string every frame? With how it was though, this is still better 👻.

[psychonic]

Hokay, I think we've sorted all of this out on irc.

I question the placement of this with 410 below it.

It is intentional to cache these as soon as we have them, rather than to do the old style of grabbing on the fly if not cached.

Maybe the authid should be compared instead of the string every frame? With how it was though, this is still better 👻.

To do that would require a duplication of logic and not overall be much of an optimization after you call a couple of extra vfuncs, add a few compares, etc.