Utilize convar cache for FindConVar. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like when the convar manager was initially written, handles persisted even after the convar was destroyed; I believe I've even read documentation to this regard. However, it looks like the cache is destroyed if the convar no longer exists: which means this is probably fine. EDIT: I'd appreciate it if someone glanced at the engine code surrounding this, but |
works as well.
|
I don't foresee any real issues here unless SM misses convars being unregistered, in which case other things would be breaking. |
psychonic
added a commit
that referenced
this pull request
Jun 12, 2014
Utilize convar cache for FindConVar (r=KyleS, r=psychonic)..
This was referenced Aug 18, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #6, FindConVar should first check SM's convar cache before traversing Source's linked list of convars to find a specific one.