Pass a handle instead of entptr to ProcessCondChange for stability. #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int client = gamehelpers->EntityToBCompatRef(pCondData->pPlayer); | ||
| if (!playerhelpers->GetGamePlayer(client)->IsInGame()) | ||
| auto *pEdict = gamehelpers->GetHandleEntity(pCondData->hPlayer); | ||
| auto *pPlayer = playerhelpers->GetGamePlayer(pEdict); |
There was a problem hiding this comment.
This is not safe on >= L4D as pEdict can be NULL (compat_wrappers doesn't check, I'm not sure about in the engine). Otherwise, as this is for TF only, everything seems more safe.
There was a problem hiding this comment.
I will make a note to fix it when we port the TF2 extension to L4D.
psychonic
added a commit
that referenced
this pull request
Apr 2, 2015
Pass a handle instead of entptr to ProcessCondChange for stability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@voided had seen some crashes on his TF2 servers after the new TF2 player conditions change detection was implemented. The crashes were in CHalfLife2::EntityToBCompatRef, called from PlayerConditionsMgr::ProcessCondChange.
This change makes it so that we pass an entity handle around instead of the raw player pointer, and checking it for validity before use in an attempt to quash the crash from the player no longer being valid.