Improve CreateNative failure message #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This confuses everyone.
|
Docs are definitely an improvement. Do we care that we call these Fake Natives internally; but Dynamic Natives to pawn? Anyone digging through code will know them by the former name. |
|
I belive the intention is that they become just "natives" in the future, and the term "fake" has confused people in the past, I figured "dynamic" was clear but happy to change/remove. I think dropping the qualifier would make the most sense if anything. |
|
Yeah; if Fake/Dynamic are ephemeral ("") qualifiers let's drop them entirely to userspace. |
|
You could even go as far as adding the name of the plugin, that has the native already registered in the second error. |
Headline
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This confuses everyone.