Fix api resource names #29
Conversation
There was a problem hiding this comment.
The idea behind this PR is excellent, but the changes kind-of threw the baby out with the bathwater.
Previously, resources with dashes in the name were impossible because they generated invalid attribute names.
Now they're impossible because the "valid" resource name with underscores ends up in the URL, instead of the original resource name with dashes, so using the resource as is causes 404 exceptions, as was reported later in #32.
| resource_class = resource_class or Resource | ||
| resource = resource_class( | ||
| api_root_url=api_root_url or self.api_root_url, | ||
| resource_name=resource_name, | ||
| resource_name=resource_valid_name, |
There was a problem hiding this comment.
This line change should be reverted, so the resource itself retains the original name.
Otherwise accessing the resource results in 404 errors:
| resource_name=resource_valid_name, | |
| resource_name=resource_name, |
| valid_name = self.correct_attribute_name(resource_name) | ||
| self._resources[valid_name] = resource | ||
| setattr(self, valid_name, resource) | ||
| self._resources[resource_valid_name] = resource |
There was a problem hiding this comment.
It seems to me that the _resources dictionary should have the original resource_name as key, rather than the fixed resource name.
| self._resources[resource_valid_name] = resource | |
| self._resources[resource_name] = resource |
(though actually this line change happened in a previous commit: #28).
No description provided.