Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE] fix hundred addition #102

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

Kakadus
Copy link
Contributor

@Kakadus Kakadus commented Nov 24, 2023

close #100
This tries to tackle the issue by requiring that a multiplier must be before a "hundred construction" so that something like "dreizehn siebenhundert" is no longer summed.

@rtxm rtxm self-requested a review November 27, 2023 09:22
@rtxm
Copy link
Collaborator

rtxm commented Nov 27, 2023

Thank you very much for your contribution. How does this behave when using the alpha2digit function?

@Kakadus
Copy link
Contributor Author

Kakadus commented Nov 27, 2023

It should be working.. I added some tests for alpha2digit. There is a github incident, but at https://github.com/Kakadus/text2num/tree/fix-hundred-addition, the commit 16f91bddf41a31545221403e6de551e883c15187 should contain it

@rtxm rtxm merged commit 95b983d into allo-media:master Nov 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

German: Numbers are falsely being added up
2 participants