chore: profileId is generated using owner #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
commented
Sep 22, 2023
thelostone-mc
commented
Sep 22, 2023
thelostone-mc
requested review from
0xKurt,
codenamejason,
0xZakk and
nfrgosselin
0xKurt
previously approved these changes
Sep 22, 2023
codenamejason
previously approved these changes
Sep 22, 2023
thelostone-mc
dismissed stale reviews from codenamejason and 0xKurt
via
57899fd
thelostone-mc
force-pushed
the
anchor-generation
branch
from
57899fd
to
c1b2289
Compare
thelostone-mc
force-pushed
the
anchor-generation
branch
from
c1b2289
to
9dfade0
Compare
0xKurt
pushed a commit
that referenced
this pull request
Oct 11, 2023
thelostone-mc
added a commit
that referenced
this pull request
Oct 30, 2023
* fix: add recipientAddress in register for RFP (#342) * fix: add recipientAddress in register for RFP refs sherlock-audit/2023-09-Gitcoin-judging#245 * changed order of and removed redundant code * simplified register function --------- Co-authored-by: 0xKurt <Kurt@Merbeth.io> * fix: add onlyPoolManager modifier to RFP setPoolActive (#340) refs sherlock-audit/2023-09-Gitcoin-judging#458 * fix: update _checkOnlyAfterAllocation logic (#337) refs: sherlock-audit/2023-09-Gitcoin-judging#839 * fix: delete existing milestone on reset (#341) refs sherlock-audit/2023-09-Gitcoin-judging#176 * fix: prevent front-running of proposalBid (#346) * fix: prevent front-running of proposalBid refs sherlock-audit/2023-09-Gitcoin-judging#497 * updated error --------- Co-authored-by: 0xKurt <Kurt@Merbeth.io> * fix: ensure allocator used credits are accounted (#339) refs sherlock-audit/2023-09-Gitcoin-judging#150 * fix: ensure votes are accounted for in qv (#338) refs sherlock-audit/2023-09-Gitcoin-judging#48 * fix: anchor creation (#348) * chore: update natspec comment for submitMilestone (#343) refs sherlock-audit/2023-09-Gitcoin-judging#259 * fix: review threshold, add test (#350) Co-authored-by: jaxcoder / <codenamejason@outlook.com> * fix: start recipientsCounter at 1 (#351) Co-authored-by: jaxcoder / <codenamejason@outlook.com> * Fix 19 (#355) * fix: handle fee on transfer token * fix broken test cases --------- Co-authored-by: 0xKurt <Kurt@Merbeth.io> * fix: add withdraw function to QVBaseStrategy (#345) * withdraw function, fundPool restriction * fix tests --------- Co-authored-by: 0xKurt <Kurt@Merbeth.io> * fix withdraw function (#356) * withdraw function * added test * update comment --------- Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com> * added recipient counter reference (#357) * fix: profileId is generated using owner #326 (#354) * chore: profileId is generated using owner * fix test * fix test * fix: update _distribute to ensure milestone can be distributed (#344) * fix: update _distribute to ensure milestone can be distributed refs sherlock-audit/2023-09-Gitcoin-judging#492 * removed uneccessary check * fix test --------- Co-authored-by: 0xKurt <Kurt@Merbeth.io> * fix: update review status (#349) * fix: registerRecipient logic for QV - accepted applications cannot reapply - handle state for rejected / pending / appealed / new registration * fix * chore: fix test/fmt * chore: update reviewRecipient logic - update reviewedByManager to track actual status - update reviewRecipient to ensure they can't recast vote once approved --------- Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com> Co-authored-by: Jaxcoder <codenamejason@outlook.com> * fix: add recieve function (#376) * fix: add recieve function refs sherlock-audit/2023-09-Gitcoin-judging#256 * fix tests * fix: fix the fee deduction logic (#375) refs sherlock-audit/2023-09-Gitcoin-judging#752 * fix: make sure to use upgradeable access control (#374) refs sherlock-audit/2023-09-Gitcoin-judging#852 * fix: milestone amount cannot be 0 (#373) refs sherlock-audit/2023-09-Gitcoin-judging#846 * fix: allow distributing only pending milestones (#372) refs sherlock-audit/2023-09-Gitcoin-judging#510 * fix: ensure distribute cannot happen without merkleRoot (#371) refs sherlock-audit/2023-09-Gitcoin-judging#723 * fix: ensure metadata is tracked in RFP (#369) refs sherlock-audit/2023-09-Gitcoin-judging#170 * add ERC721- and ERC1155 Holder (#378) * fix: pass msg.value in registerRecipient (#377) refs sherlock-audit/2023-09-Gitcoin-judging#20 * added msg.value check (#379) * added msg.value check * fix test * Fix 547 (#381) * check balance before and after transfer * fix lib * chore: ensure review can be done during allocation (#380) refs sherlock-audit/2023-09-Gitcoin-judging#579 * added frontrun test (#383) * double check amount (#385) * Reject only pending milestones (#384) * deploy anchor using (#387) some cleanup * chore: fix review status (#404) * After audit (#399) * chore: improve deploy scripts (#389) * chore: update deploy scripts - adding read/write to config - version upgrades - changing scripts * downgrade * chore: some deploy updates Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com> Co-authored-by: 0xKurt <Kurt@Merbeth.io> * chore: latest from pairing Co-authored-by: Jaxcoder <codenamejason@outlook.com> Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com> Co-authored-by: 0xKurt <Kurt@Merbeth.io> * chore: adds HH task to write md file content * add deployment verification --------- Co-authored-by: 0xKurt <Kurt@Merbeth.io> Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com> * chore: update Allo to set owner on init (#395) * bug: fix poc to ensure funds are sent to vault (#400) * bug: fix poc * fix indent * Integrate bun (#401) * chore: update to use bun > yarn * chore: cleanup --------- Co-authored-by: Jaxcoder <codenamejason@outlook.com> * Add deploy checklist / update deploy scripts (#392) * chore: update supported network list/update config - some final script/config updates-verify iss - first run on arbitrum-goerli/passing - adding gas snapshot/reporter for deploy est - tweak gas rep output/solidity gas rep - automate all networks - update .gitignore/update output to .log - work on deployment script(s) * chore: cleanup - remove pretty num - remove snapshot - update text * chore: toml update/config update * tweak --------- Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com> * chore: add upgrade scripts Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com> * chore: deploy script updates (#402) * upgrade via multisig (#403) * chore: add transferProxyAdminOwner * chore: add defender --------- Co-authored-by: jaxcoder / <codenamejason@outlook.com> Co-authored-by: 0xKurt <Kurt@Merbeth.io> --------- Co-authored-by: 0xKurt <Kurt@Merbeth.io> Co-authored-by: jaxcoder / <codenamejason@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
fixes: #327
refs sherlock-audit/2023-09-Gitcoin-judging#7
This would enable GiveEth to optionally create profiles on behalf of the profile owner but will hold no ownership of the profile