Omit optional parameters when none are passed in

lib/nacre/concerns/getable.rb

@@ -2,12 +2,16 @@ module Nacre::Getable
 
   def get(range)
     if range?(range)
-      request_url = build_request_url(url, range, request_options)
-    else
       request_url = build_request_url(url, range)
+    else
+      request_url = build_request_url(url, range, request_options)
     end
     response = link.get(request_url)
-    from_json(response.body)
+    if response.success?
+      from_json(response.body)
+    else
+      raise ArgumentError, "Request error: #{request_url}\n#{response.body}"
+    end
   end
 
   private
@@ -29,6 +33,6 @@ def build_request_url(url, query, options = nil)
   end
 
   def range?(arg)
-    /\d-\d/ === arg && /\d,\d/ === arg
+    /\d[,-]\d?/ === arg
   end
 end

lib/nacre/request_url.rb

@@ -44,7 +44,11 @@ def pagination_params
     end
 
     def options
-      ["includeOptional=#{@options.join(',')}"]
+      if @options
+        ["includeOptional=#{@options.join(',')}"]
+      else
+        []
+      end
     end
 
     def arguments

spec/lib/nacre/order_collection_spec.rb

@@ -42,11 +42,7 @@
     let(:get_options) do
       {
         search_url: order_service_url,
-        ids: range,
-        options: [
-          'customFields',
-          'nullCustomFields'
-        ]
+        ids: range
       }
     end
 
@@ -63,7 +59,6 @@
       @collection = described_class.get(range)
     end
 
-
     it 'should query the API server' do
       expect(a_request(:get, @url.to_s)).to have_been_made
     end

spec/lib/nacre/product_collection_spec.rb

@@ -39,11 +39,7 @@
     let(:get_options) do
       {
         search_url: product_service_url,
-        ids: range,
-        options: [
-          'customFields',
-          'nullCustomFields'
-        ]
+        ids: range
       }
     end