This repository has been archived by the owner on May 4, 2022. It is now read-only.
Use "public-api" for URI instead of version no #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brightpearl are deprecating the use of specific version numbers in the URI for their public API. Instead, you should use "public-api" in the same location within the URI. - Change "2.0.0" to "public-api". - Don't allow this change to be overridden in configuration. This change will result in the config ignoring API versions being set, so the change is non-breaking. I have tested the new URI's and they work.
| @@ -31,7 +30,7 @@ | |||
| end | |||
|
|
|||
| it "should have the correct Resource URL" do | |||
| expect(config.resource_url).to eql("https://ws-eu1.brightpearl.com/2.0.0/%s" % [ENV["NACRE_USER_ID"]]) | |||
| expect(config.resource_url).to eql("https://ws-eu1.brightpearl.com/public-api/%s" % [ENV["NACRE_USER_ID"]]) | |||
There was a problem hiding this comment.
Line is too long. [113/80]
Favor format over String#%.
- Shorten lines - Move hard-to-read variables into simple lets. - Use interpolation instead of string formatting
|
Brightpearl https://www.brightpearl.com/support/documentation/features-approaching-end-life
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brightpearl are deprecating the use of specific version numbers in the URI for their public API. Instead, you should use "public-api" in the same location within the URI.
This change will result in the config ignoring API versions being set, so the change is non-breaking.
I have tested the new URI's and they work.